You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2020/06/18 07:58:16 UTC
[GitHub] [spark] liucht-inspur opened a new pull request #28855: [SPARK-31871][CORE][WEBUI][2.3] History page and Executors tab page show the correct sort icons
liucht-inspur opened a new pull request #28855:
URL: https://github.com/apache/spark/pull/28855
### What changes were proposed in this pull request?
This PR was designed to solve the problem of incorrect display of History page and Executor tab page ICONS in spark 2.3.
Fixed the correct path for the display icon.
### Why are the changes needed?
Sorting doesn't show icons correctly, especially when the list is long and confusing.
### Does this PR introduce _any_ user-facing change?
No.
### How was this patch tested?
Screenshots attached.
change before:
History page:
Executors tab page:
change after:
History page:
Executors tab page:
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] sarutak edited a comment on pull request #28855: [SPARK-31871][CORE][WEBUI][2.3] History page and Executors tab page show the correct sort icons
Posted by GitBox <gi...@apache.org>.
sarutak edited a comment on pull request #28855:
URL: https://github.com/apache/spark/pull/28855#issuecomment-645993471
> Oh! Are 2.2, 2.1, and 2.0 no longer maintained?
Yes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] liucht-inspur commented on pull request #28855: [SPARK-31871][CORE][WEBUI][2.3] History page and Executors tab page show the correct sort icons
Posted by GitBox <gi...@apache.org>.
liucht-inspur commented on pull request #28855:
URL: https://github.com/apache/spark/pull/28855#issuecomment-646391545
Thank you all.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun commented on pull request #28855: [SPARK-31871][CORE][WEBUI][2.3] History page and Executors tab page show the correct sort icons
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on pull request #28855:
URL: https://github.com/apache/spark/pull/28855#issuecomment-646319722
Yes. , @liucht-inspur . Please see `Maintenance Releases and EOL` section of https://spark.apache.org/versioning-policy.html .
+1 for @sarutak 's advice (closing this PR).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun commented on pull request #28855: [SPARK-31871][CORE][WEBUI][2.3] History page and Executors tab page show the correct sort icons
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on pull request #28855:
URL: https://github.com/apache/spark/pull/28855#issuecomment-646354725
FYI, Apache Spark 3.0.0 is released.
- https://spark.apache.org/releases/spark-release-3-0-0.html
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] sarutak commented on pull request #28855: [SPARK-31871][CORE][WEBUI][2.3] History page and Executors tab page show the correct sort icons
Posted by GitBox <gi...@apache.org>.
sarutak commented on pull request #28855:
URL: https://github.com/apache/spark/pull/28855#issuecomment-645864667
Hi @liucht-inspur , sorry but `branch-2.3` is no longer maintained so please close this PR?
You can see our versioning policy [here](https://spark.apache.org/versioning-policy.html).
Thanks!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] sarutak commented on pull request #28855: [SPARK-31871][CORE][WEBUI][2.3] History page and Executors tab page show the correct sort icons
Posted by GitBox <gi...@apache.org>.
sarutak commented on pull request #28855:
URL: https://github.com/apache/spark/pull/28855#issuecomment-645993471
> Oh! Are 2.2, 2.1, and 2.0 no longer maintained?
Yes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #28855: [SPARK-31871][CORE][WEBUI][2.3] History page and Executors tab page show the correct sort icons
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #28855:
URL: https://github.com/apache/spark/pull/28855#issuecomment-645850398
Can one of the admins verify this patch?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #28855: [SPARK-31871][CORE][WEBUI][2.3] History page and Executors tab page show the correct sort icons
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #28855:
URL: https://github.com/apache/spark/pull/28855#issuecomment-645850954
Can one of the admins verify this patch?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #28855: [SPARK-31871][CORE][WEBUI][2.3] History page and Executors tab page show the correct sort icons
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #28855:
URL: https://github.com/apache/spark/pull/28855#issuecomment-645850398
Can one of the admins verify this patch?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] liucht-inspur commented on pull request #28855: [SPARK-31871][CORE][WEBUI][2.3] History page and Executors tab page show the correct sort icons
Posted by GitBox <gi...@apache.org>.
liucht-inspur commented on pull request #28855:
URL: https://github.com/apache/spark/pull/28855#issuecomment-645945188
> Hi @liucht-inspur , sorry but `branch-2.3` is no longer maintained so please close this PR?
> You can see our versioning policy [here](https://spark.apache.org/versioning-policy.html).
> Thanks!
Oh! Are 2.2, 2.1, and 2.0 no longer maintained?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun closed pull request #28855: [SPARK-31871][CORE][WEBUI][2.3] History page and Executors tab page show the correct sort icons
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun closed pull request #28855:
URL: https://github.com/apache/spark/pull/28855
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org