You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@maven.apache.org by "Andreas Sewe (Jira)" <ji...@apache.org> on 2020/06/01 17:40:00 UTC
[jira] [Commented] (JXR-154) xref-test package summary lists also
classes from main source directories
[ https://issues.apache.org/jira/browse/JXR-154?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17121201#comment-17121201 ]
Andreas Sewe commented on JXR-154:
----------------------------------
I had a look at the code myself. It seems that within the scope of a {{JXR}} instance, there should be one and only one fresh instance of {{FileManager}} and {{PackageManager}} – and possibly also {{JavaCodeTransform}}, although that is a bit weirder, as there is a {{JXR.setTransformer}} method in {{JXR}}'s interface; this makes it impossible to guarantee that {{JXR}} and {{JavaCodeTransform}} use the same {{PackageManager}}.
> xref-test package summary lists also classes from main source directories
> -------------------------------------------------------------------------
>
> Key: JXR-154
> URL: https://issues.apache.org/jira/browse/JXR-154
> Project: Maven JXR
> Issue Type: Bug
> Components: maven2 jxr plugin
> Affects Versions: 3.1.0
> Environment: Apache Maven 3.6.3 (cecedd343002696d0abb50b32b541b8a6ba2883f)
> Maven home: /opt/apache-maven
> Java version: 1.8.0_201, vendor: Oracle Corporation, runtime: /usr/lib/jvm/java-8-oracle/jre
> Default locale: en_CA, platform encoding: UTF-8
> OS name: "linux", version: "4.15.0-101-generic", arch: "amd64", family: "unix
> Reporter: Andreas Sewe
> Assignee: Robert Scholte
> Priority: Major
> Labels: regression
> Fix For: next-release
>
> Attachments: it.patch
>
>
> This is a regression from 3.0.0:
> The {{xref-test}} report lists not only classes from the test source directories, but also from the main source directories in its {{package-summary.html}}. This is not only unexpected, but the respective links to the actual sources are also dead.
> Using {{git bisect}}, I was able to narrow this bug (introduced between jxr-3.0.0 and 82193ede1e036a0e66e1591295f2311982a17c73) down to the following commit:
> {noformat}
> b4117e7ef0795eed02e2ace3c9c4c310f5391aac is the first bad commit
> commit b4117e7ef0795eed02e2ace3c9c4c310f5391aac
> Author: rfscholte <rf...@apache.org>
> Date: Fri Jul 5 00:11:29 2019 +0200 [JXR-142] Switch to JSR330 Dependency Injection,
> [JXR-144] Require Maven 3.1.0:040000 040000 9bd9a415b2e3d94406911ca475603de67b504be9 dc78032a3f63c806041f360da96e9468c955f421 M maven-jxr-plugin
> :040000 040000 a9bbe183fcbc2b22afae203be4483fd9c1dd2a1b c15f3e82de0050ffa3834c0ff076fa8a6b57c31a M maven-jxr
> :100644 100644 e61a9f56ba6ea12165b72967873f72ed7611f894 be2f7ecc125a573c7316c048dc521c40c60aa5f1 M pom.xml
> bisect run success {noformat}
> using the attached patch [^it.patch] to the most basic integration test, {{simple-project}}.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)