[GitHub] [incubator-superset] suddjian commented on a change in pull request #8876: [dashboard] Modal for editing dashboard properties & metadata

[GitBox <gi...@apache.org>]

suddjian commented on a change in pull request #8876: [dashboard] Modal for editing dashboard properties & metadata
URL: https://github.com/apache/incubator-superset/pull/8876#discussion_r365943605
 
 

 ##########
 File path: superset/assets/src/dashboard/actions/dashboardLayout.js
 ##########
 @@ -213,10 +213,8 @@ export function handleComponentDrop(dropResult) {
     } else if (
       destination &&
       source &&
-      !(
-        // ensure it has moved
-        (destination.id === source.id && destination.index === source.index)
-      )
+      !// ensure it has moved
 
 Review comment:
   I'm not sure how this change got in. I think it might have been the result of autoformatting. Shouldn't be a problem for the interpreter, but I'll change it back anyway.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org