You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@pekko.apache.org by "pjfanning (via GitHub)" <gi...@apache.org> on 2023/06/19 20:28:54 UTC
[GitHub] [incubator-pekko] pjfanning opened a new pull request, #427: Delete PrettyByteString.scala
pjfanning opened a new pull request, #427:
URL: https://github.com/apache/incubator-pekko/pull/427
Doesn't seem to be used.
And any comment that has 'based on' and a link to code is going to cause us problems in code reviews. Licensing and other concerns.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko] mdedetrich commented on pull request #427: Delete PrettyByteString.scala
Posted by "mdedetrich (via GitHub)" <gi...@apache.org>.
mdedetrich commented on PR #427:
URL: https://github.com/apache/incubator-pekko/pull/427#issuecomment-1597776525
Did you check that this isn't used in all of Pekkos modules or just this one?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko] He-Pin commented on pull request #427: [DRAFT] Delete PrettyByteString.scala
Posted by "He-Pin (via GitHub)" <gi...@apache.org>.
He-Pin commented on PR #427:
URL: https://github.com/apache/incubator-pekko/pull/427#issuecomment-1597869337
It may be used in http or debugging i think
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko] pjfanning commented on pull request #427: Delete PrettyByteString.scala
Posted by "pjfanning (via GitHub)" <gi...@apache.org>.
pjfanning commented on PR #427:
URL: https://github.com/apache/incubator-pekko/pull/427#issuecomment-1597780956
I found one in a test in pekko-http-core
https://github.com/search?q=repo%3Aapache%2Fincubator-pekko-http+PrettyByteString&type=code
Looks fixable - it should be feasible to modify the test.
I won't do anything for next few days. I've sent a mesage to @justinmclean about this class and the fact that @jrudolph was a Lightbend staff member - so there is a string argument that we don't need special license treatment for this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko] jrudolph commented on pull request #427: [DRAFT] Delete PrettyByteString.scala
Posted by "jrudolph (via GitHub)" <gi...@apache.org>.
jrudolph commented on PR #427:
URL: https://github.com/apache/incubator-pekko/pull/427#issuecomment-1598528530
Yes, can go. In this case, "based" meant basically upstreaming some debugging code from akka-http to akka. The http module has similar/same code in `LogByteStringTools.scala` which can be used in the tests instead. I'll add a PR for pekko-http.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko] jrudolph commented on pull request #427: [DRAFT] Delete PrettyByteString.scala
Posted by "jrudolph (via GitHub)" <gi...@apache.org>.
jrudolph commented on PR #427:
URL: https://github.com/apache/incubator-pekko/pull/427#issuecomment-1598533718
https://github.com/apache/incubator-pekko-http/pull/191
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko] pjfanning commented on pull request #427: Delete PrettyByteString.scala
Posted by "pjfanning (via GitHub)" <gi...@apache.org>.
pjfanning commented on PR #427:
URL: https://github.com/apache/incubator-pekko/pull/427#issuecomment-1598571655
https://github.com/apache/incubator-pekko-http/pull/191 is merged so this is now safe to merge.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko] mdedetrich merged pull request #427: Delete PrettyByteString.scala
Posted by "mdedetrich (via GitHub)" <gi...@apache.org>.
mdedetrich merged PR #427:
URL: https://github.com/apache/incubator-pekko/pull/427
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org