You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@beam.apache.org by GitBox <gi...@apache.org> on 2020/05/01 10:16:19 UTC
[GitHub] [beam] mxm commented on a change in pull request #11578: [BEAM-8025] Increase the number of retrials en retrial delay in case of load in CassandraIOTest
mxm commented on a change in pull request #11578:
URL: https://github.com/apache/beam/pull/11578#discussion_r418487133
##########
File path: sdks/java/io/cassandra/src/test/java/org/apache/beam/sdk/io/cassandra/CassandraIOTest.java
##########
@@ -153,18 +153,22 @@ public static void beforeClass() throws Exception {
private static Cluster buildCluster(CassandraEmbeddedServerBuilder builder) {
int tried = 0;
Review comment:
```suggestion
Exception exception = null;
int tried = 0;
```
##########
File path: sdks/java/io/cassandra/src/test/java/org/apache/beam/sdk/io/cassandra/CassandraIOTest.java
##########
@@ -153,18 +153,22 @@ public static void beforeClass() throws Exception {
private static Cluster buildCluster(CassandraEmbeddedServerBuilder builder) {
int tried = 0;
- while (tried < 3) {
+ int delay = 5000;
+ while (tried < 5) {
try {
return builder.buildNativeCluster();
} catch (NoHostAvailableException e) {
Review comment:
I couldn't find that this exception of type RuntimeException is thrown during cluster startup. We may want to catch all `Exception` here.
##########
File path: sdks/java/io/cassandra/src/test/java/org/apache/beam/sdk/io/cassandra/CassandraIOTest.java
##########
@@ -153,18 +153,22 @@ public static void beforeClass() throws Exception {
private static Cluster buildCluster(CassandraEmbeddedServerBuilder builder) {
int tried = 0;
- while (tried < 3) {
+ int delay = 5000;
+ while (tried < 5) {
try {
return builder.buildNativeCluster();
} catch (NoHostAvailableException e) {
tried++;
Review comment:
```suggestion
if (exception == null) {
exception = e;
} else {
exception.addSuppressed(e);
}
tried++;
```
##########
File path: sdks/java/io/cassandra/src/test/java/org/apache/beam/sdk/io/cassandra/CassandraIOTest.java
##########
@@ -153,18 +153,22 @@ public static void beforeClass() throws Exception {
private static Cluster buildCluster(CassandraEmbeddedServerBuilder builder) {
int tried = 0;
- while (tried < 3) {
+ int delay = 5000;
+ while (tried < 5) {
try {
return builder.buildNativeCluster();
} catch (NoHostAvailableException e) {
tried++;
try {
- Thread.sleep(1000L);
+ Thread.sleep(delay);
} catch (InterruptedException e1) {
Review comment:
```suggestion
} catch (InterruptedException e1) {
Thread.currentThread().interrupt();
throw new RuntimeException("interrupted");
}
```
##########
File path: sdks/java/io/cassandra/src/test/java/org/apache/beam/sdk/io/cassandra/CassandraIOTest.java
##########
@@ -153,18 +153,22 @@ public static void beforeClass() throws Exception {
private static Cluster buildCluster(CassandraEmbeddedServerBuilder builder) {
int tried = 0;
- while (tried < 3) {
+ int delay = 5000;
+ while (tried < 5) {
try {
return builder.buildNativeCluster();
} catch (NoHostAvailableException e) {
tried++;
try {
- Thread.sleep(1000L);
+ Thread.sleep(delay);
} catch (InterruptedException e1) {
}
}
}
- throw new RuntimeException("Unable to create embedded Cassandra cluster");
+ throw new RuntimeException(
+ String.format(
+ "Unable to create embedded Cassandra cluster: tried %d times with %d delay",
+ tried, delay));
Review comment:
```suggestion
throw new RuntimeException(
String.format(
"Unable to create embedded Cassandra cluster: tried %d times with %d delay",
tried, delay),
exception);
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org