You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hbase.apache.org by "Andrew Purtell (JIRA)" <ji...@apache.org> on 2013/06/27 07:08:23 UTC
[jira] [Resolved] (HBASE-8811) REST service ignores misspelled
"check=" parameter, causing unexpected mutations
[ https://issues.apache.org/jira/browse/HBASE-8811?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Andrew Purtell resolved HBASE-8811.
-----------------------------------
Resolution: Fixed
Fix Version/s: 0.94.9
0.95.2
0.98.0
Assignee: Chip Salzenberg
Committed trivial patch for serious issue. Added unit test to TestRowResource for this case. New unit test and REST tests pass on trunk, 0.95, and 0.94.
> REST service ignores misspelled "check=" parameter, causing unexpected mutations
> --------------------------------------------------------------------------------
>
> Key: HBASE-8811
> URL: https://issues.apache.org/jira/browse/HBASE-8811
> Project: HBase
> Issue Type: Bug
> Components: REST
> Affects Versions: 0.98.0, 0.95.2, 0.94.9
> Reporter: Chip Salzenberg
> Assignee: Chip Salzenberg
> Priority: Critical
> Fix For: 0.98.0, 0.95.2, 0.94.9
>
> Attachments: 8811-0.94.patch, 8811.patch
>
>
> In rest.RowResource.update(), this code keeps executing a request if a misspelled check= parameter is provided.
> {noformat}
> if (CHECK_PUT.equalsIgnoreCase(check)) {
> return checkAndPut(model);
> } else if (CHECK_DELETE.equalsIgnoreCase(check)) {
> return checkAndDelete(model);
> } else if (check != null && check.length() > 0) {
> LOG.warn("Unknown check value: " + check + ", ignored");
> }
> {noformat}
> By my reading of the code, this results in the provided cell value that was intended as a check instead being treated as a mutation, which is sure to destroy user data. Thus the priority of this bug, as it can cause corruption.
> I suggest that a better reaction than a warning would be, approximately:
> {noformat}
> return Response.status(Response.Status.BAD_REQUEST)
> .type(MIMETYPE_TEXT).entity("Invalid check value '" + check + "'")
> .build();
> {noformat}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira