You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@activemq.apache.org by clebertsuconic <gi...@git.apache.org> on 2015/05/11 18:16:42 UTC

[GitHub] activemq-artemis pull request: Fixes URISchema setFactory(..)

GitHub user clebertsuconic opened a pull request:

    https://github.com/apache/activemq-artemis/pull/245

    Fixes URISchema setFactory(..)

    

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/clebertsuconic/activemq-6 master

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/activemq-artemis/pull/245.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #245
    
----
commit b346c2d4ff9cff840e4bdacc8573092f1c7c6317
Author: Thiago Kronig <ca...@uolinc.com>
Date:   2015-05-05T17:30:03Z

    Fixes URISchema setFactory(..)

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] activemq-artemis pull request: ARTEMIS-201 warn of potential OOME

Posted by clebertsuconic <gi...@git.apache.org>.

Github user clebertsuconic commented on the pull request:

    https://github.com/apache/activemq-artemis/pull/245#issuecomment-159135245
  
    on a second though it's not really needed. I will merge it


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] activemq-artemis pull request: ARTEMIS-201 warn of potential OOME

Posted by jbertram <gi...@git.apache.org>.

Github user jbertram commented on the pull request:

    https://github.com/apache/activemq-artemis/pull/245#issuecomment-159054551
  
    The scenario you outline (X addresses with Y max-size-bytes and Z heap-size that would require N addresses to go into paging mode before an OOME occurs) is just one possible scenario.  
    The scenario I outlined previously is equally valid (1 address with Y max-size-bytes and Y/2 heap-size) and no paging would be involved before an OOME occurred so your suggested message wouldn't make sense.
    
    As far as using getting scared of this WARN message when they have many shallow destinations that never receive enough messages to reach max-size-bytes I think they should be scared because their broker is in a vulnerable position.  If something goes wrong and they start getting increased message production then they'll go OOME due to their sub-optimal configuration.
    
    Whether or not it should be a WARN or an INFO is debatable, IMO. Being vulnerable to an OOME if someone dumps a bunch of messages on the server seems fairly serious to me.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] activemq-artemis pull request: ARTEMIS-201 warn of potential OOME

Posted by clebertsuconic <gi...@git.apache.org>.

Github user clebertsuconic commented on the pull request:

    https://github.com/apache/activemq-artemis/pull/245#issuecomment-158999892
  
    @jbertram  think the following:
    
    An user sets 100 destinations.. with 100M cache... the memory would be able to fit only 10 paged destinations..
    
    The user has monitoring in place... whenever a consumer drops and page increases he will take action and restart the client...
    
    
    that means... he would make sure he wouldn't get to the 100 paged message using monitoring tools...
    
    
    That's a valid scenario.. with your messages users will assume they must have memory available at all times.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] activemq-artemis pull request: ARTEMIS-201 warn of potential OOME

Posted by jbertram <gi...@git.apache.org>.

Github user jbertram commented on the pull request:

    https://github.com/apache/activemq-artemis/pull/245#issuecomment-159003967
  
    Even though they have monitoring in place to avoid the OOME, the OOME is still possible if something were to malfunction with regards to the monitoring.  I think the WARN is still valid.  The broker has no way of knowing how it's actually going to be used.  It only knows how it has been configured.  Users can (and do) ignore WARN messages all the time when they know the messages don't apply to their use-case, but that doesn't mean the WARN messages aren't valid for lots of other use-cases.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] activemq-artemis pull request: ARTEMIS-201 warn of potential OOME

Posted by clebertsuconic <gi...@git.apache.org>.

Github user clebertsuconic commented on the pull request:

    https://github.com/apache/activemq-artemis/pull/245#issuecomment-159134310
  
    Can you at least say "when you have more than X destinations in page mode" on your log message?
    
    X = Memory Size / Page MAX-Size... just as an approximation 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] activemq-artemis pull request: ARTEMIS-201 warn of potential OOME

Posted by clebertsuconic <gi...@git.apache.org>.

Github user clebertsuconic commented on the pull request:

    https://github.com/apache/activemq-artemis/pull/245#issuecomment-159010682
  
    My issue is not with showing a message.. it's with the message.    I think it should say something like.. You would run out of memory when you have more than X destinations in page mode.
    
    Notice that you could have many shallow destinations that never receive more than a few messages a day... and users will get scared for that message....
    
    
    it shouldn't even be a warning.. it could be an INFO!


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] activemq-artemis pull request: ARTEMIS-201 warn of potential OOME

Posted by asfgit <gi...@git.apache.org>.

Github user asfgit closed the pull request at:

    https://github.com/apache/activemq-artemis/pull/245


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---