You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "loicalleyne (via GitHub)" <gi...@apache.org> on 2025/08/15 15:56:00 UTC
[PR] Use ParseFloat with json.Number in Int64/Uint64 Builders' UnmarshalOne [arrow-go]
loicalleyne opened a new pull request, #475:
URL: https://github.com/apache/arrow-go/pull/475
### Rationale for this change
Addresses [#474](https://github.com/apache/arrow-go/issues/474#issue-3325545839)
### What changes are included in this PR?
Replaced `strconv.ParseInt`/`strconv.ParseUint` with `strconv.ParseFloat` in Int64/Uint64Builder.UnmarshalOne
### Are these changes tested?
Existing tests pass.
### Are there any user-facing changes?
No
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Use ParseFloat with json.Number in Int64/Uint64 Builders' UnmarshalOne [arrow-go]
Posted by "Dhruvit96 (via GitHub)" <gi...@apache.org>.
Dhruvit96 commented on PR #475:
URL: https://github.com/apache/arrow-go/pull/475#issuecomment-3239349059
FWIW, while exploring issues and PRs, I noticed that using ParseFloat isn’t the right solution. The problem is that it loses precision for integers larger than 2^53 (for example, "9007199254740993" gets converted to 9.007199254740993e+15).
ref: https://go.dev/play/p/DHzSTvI07iE
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Use ParseFloat with json.Number in Int64/Uint64 Builders' UnmarshalOne [arrow-go]
Posted by "zeroshade (via GitHub)" <gi...@apache.org>.
zeroshade commented on PR #475:
URL: https://github.com/apache/arrow-go/pull/475#issuecomment-3194009568
Do we need to do this for *ALL* the integer types? not just int64/uint64?
Can you add a relevant test case for this please?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Use ParseFloat with json.Number in Int64/Uint64 Builders' UnmarshalOne [arrow-go]
Posted by "zeroshade (via GitHub)" <gi...@apache.org>.
zeroshade commented on PR #475:
URL: https://github.com/apache/arrow-go/pull/475#issuecomment-5243127976
@loicalleyne Converting to **draft** — this PR doesn't yet meet our [Pull Request quality criteria](https://github.com/apache/arrow-go/blob/main/CONTRIBUTING.md).
- :x: **Merge conflicts** — this branch conflicts with `main`. See [docs](https://arrow.apache.org/docs/developers/guide/index.html).
> **Note:** Your branch is **483 commits behind `main`**. Please rebase and push again to get up-to-date CI results.
See the linked criteria for how to fix each item, then mark the PR "Ready for review". This is **not** a rejection — just an invitation to bring the PR up to standard. No rush.
---
_Note: This comment was drafted by an AI-assisted triage tool run by a maintainer, and may contain mistakes. Once you have addressed the points above, an Apache Arrow Go maintainer — a real person — will take the next look at your PR. If anything here looks wrong, say so on the PR and a maintainer will follow up. See [CONTRIBUTING.md](https://github.com/apache/arrow-go/blob/main/CONTRIBUTING.md) for the project's contribution conventions._
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org