You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tomcat.apache.org by cr...@apache.org on 2002/01/18 23:14:08 UTC
cvs commit: jakarta-tomcat-4.0/catalina/src/share/org/apache/catalina/session StandardSession.java
craigmcc 02/01/18 14:14:08
Modified: catalina/src/share/org/apache/catalina/session
StandardSession.java
Log:
Remove the redundant unbinding of session attriutes in writeObject() -- the
decision of whether or not this should be done is not appropriate here.
Remy, are you OK with me porting this to the 4.0.2 branch?
Submitted by: David Lecomber <ds...@ts.com>
Revision Changes Path
1.26 +5 -14 jakarta-tomcat-4.0/catalina/src/share/org/apache/catalina/session/StandardSession.java
Index: StandardSession.java
===================================================================
RCS file: /home/cvs/jakarta-tomcat-4.0/catalina/src/share/org/apache/catalina/session/StandardSession.java,v
retrieving revision 1.25
retrieving revision 1.26
diff -u -r1.25 -r1.26
--- StandardSession.java 31 Jul 2001 02:00:02 -0000 1.25
+++ StandardSession.java 18 Jan 2002 22:14:07 -0000 1.26
@@ -1,7 +1,7 @@
/*
- * $Header: /home/cvs/jakarta-tomcat-4.0/catalina/src/share/org/apache/catalina/session/StandardSession.java,v 1.25 2001/07/31 02:00:02 craigmcc Exp $
- * $Revision: 1.25 $
- * $Date: 2001/07/31 02:00:02 $
+ * $Header: /home/cvs/jakarta-tomcat-4.0/catalina/src/share/org/apache/catalina/session/StandardSession.java,v 1.26 2002/01/18 22:14:07 craigmcc Exp $
+ * $Revision: 1.26 $
+ * $Date: 2002/01/18 22:14:07 $
*
* ====================================================================
*
@@ -115,7 +115,7 @@
* @author Craig R. McClanahan
* @author Sean Legassick
* @author <a href="mailto:jon@latchkey.com">Jon S. Stevens</a>
- * @version $Revision: 1.25 $ $Date: 2001/07/31 02:00:02 $
+ * @version $Revision: 1.26 $ $Date: 2002/01/18 22:14:07 $
*/
class StandardSession
@@ -1316,7 +1316,6 @@
String keys[] = keys();
ArrayList saveNames = new ArrayList();
ArrayList saveValues = new ArrayList();
- ArrayList unbinds = new ArrayList();
for (int i = 0; i < keys.length; i++) {
Object value = null;
synchronized (attributes) {
@@ -1327,8 +1326,7 @@
else if (value instanceof Serializable) {
saveNames.add(keys[i]);
saveValues.add(value);
- } else
- unbinds.add(keys[i]);
+ }
}
// Serialize the attribute count and the Serializable attributes
@@ -1348,14 +1346,7 @@
if (debug >= 2)
log(" storing attribute '" + saveNames.get(i) +
"' with value NOT_SERIALIZED");
- unbinds.add(saveNames.get(i));
}
- }
-
- // Unbind the non-Serializable attributes
- Iterator names = unbinds.iterator();
- while (names.hasNext()) {
- removeAttribute((String) names.next());
}
}
--
To unsubscribe, e-mail: <ma...@jakarta.apache.org>
For additional commands, e-mail: <ma...@jakarta.apache.org>
Re: cvs commit: jakarta-tomcat-4.0/catalina/src/share/org/apache/catalina/session StandardSession.java
Posted by Remy Maucherat <re...@apache.org>.
> craigmcc 02/01/18 14:14:08
>
> Modified: catalina/src/share/org/apache/catalina/session
> StandardSession.java
> Log:
> Remove the redundant unbinding of session attriutes in writeObject() --
the
> decision of whether or not this should be done is not appropriate here.
>
> Remy, are you OK with me porting this to the 4.0.2 branch?
>
> Submitted by: David Lecomber <ds...@ts.com>
+1. Last change before I tag then.
Remy
--
To unsubscribe, e-mail: <ma...@jakarta.apache.org>
For additional commands, e-mail: <ma...@jakarta.apache.org>