[jira] [Commented] (ARROW-2035) [C++] Update vendored cpplint.py to a Py3-compatible one

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/ARROW-2035?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16339542#comment-16339542 ] 

ASF GitHub Bot commented on ARROW-2035:
---------------------------------------

pitrou commented on a change in pull request #1516: ARROW-2035: [C++] Update vendored cpplint.py to a Py3-compatible one
URL: https://github.com/apache/arrow/pull/1516#discussion_r163915446
 
 

 ##########
 File path: cpp/CMakeLists.txt
 ##########
 @@ -447,7 +447,7 @@ if (UNIX)
   add_custom_target(lint ${CPPLINT_BIN}
   --verbose=2
   --linelength=90
-  --filter=-whitespace/comments,-readability/todo,-build/header_guard,-build/c++11,-runtime/references,-build/include_order
+  --filter=-whitespace/comments,-readability/todo,-build/header_guard,-build/c++11,-runtime/references,-build/include_order,-build/include_what_you_use
 
 Review comment:
   Otherwise you get errors such as:
   ```
   /home/antoine/arrow/cpp/src/plasma/plasma.h:123:  Add #include <memory> for unique_ptr<>  [build/include_what_you_use] [4]
   ```

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


> [C++] Update vendored cpplint.py to a Py3-compatible one
> --------------------------------------------------------
>
>                 Key: ARROW-2035
>                 URL: https://issues.apache.org/jira/browse/ARROW-2035
>             Project: Apache Arrow
>          Issue Type: Improvement
>          Components: C++
>            Reporter: Wes McKinney
>            Assignee: Antoine Pitrou
>            Priority: Major
>              Labels: pull-request-available
>
> See https://github.com/cpplint/cpplint (BSD 3-clause)



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)