You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@mynewt.apache.org by "ASF subversion and git services (JIRA)" <ji...@apache.org> on 2017/06/19 23:41:00 UTC

[jira] [Commented] (MYNEWT-787) serial boot loader - newtmgr buffer overruns

    [ https://issues.apache.org/jira/browse/MYNEWT-787?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16054949#comment-16054949 ] 

ASF subversion and git services commented on MYNEWT-787:
--------------------------------------------------------

Commit 09408a3fa9d24d5f7bb2436867e247b48e3b58ae in incubator-mynewt-core's branch refs/heads/master from [~ccollins476]
[ https://gitbox.apache.org/repos/asf?p=incubator-mynewt-core.git;h=09408a3 ]

MYNEWT-787 serial boot loader - nmp buf overruns

The serial boot loader fails to process some newtmgr commands:

1. The image list response is too large for the outgoing buffer.
2. The "new" newtmgr sends large image chunks in its image upload
   requests. These chunks are too large for the serial boot loader's
   input buffer.

The fixes are as follows:
1. Increase the outgoing buffer size from 48 to 80.
2. Increase the incoming buffer size from 128 to 512.
3. Return an error rather than overrun the output buffer.


> serial boot loader - newtmgr buffer overruns
> --------------------------------------------
>
>                 Key: MYNEWT-787
>                 URL: https://issues.apache.org/jira/browse/MYNEWT-787
>             Project: Mynewt
>          Issue Type: New Feature
>      Security Level: Public(Viewable by anyone) 
>            Reporter: Christopher Collins
>            Assignee: Christopher Collins
>             Fix For: v1_1_0_rel
>
>
> (Pull request: https://github.com/apache/incubator-mynewt-core/pull/340)
> The serial boot loader fails to process some newtmgr commands:
> 1. The image list response is too large for the outgoing buffer.
> 2. The "new" newtmgr sends large image chunks in its image upload requests.  These chunks are too large for the serial boot loader's input buffer.
> The fixes are as follows:
> 1. Increase the outgoing buffer size from 48 to 80.
> 2. Increase the incoming buffer size from 128 to 512.
> 3. Return an error rather than overrun the output buffer.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)