[Impala-ASF-CR] IMPALA-5377: Impala may crash if given a fragment instance while restarting

["Alex Behm (Code Review)" <ge...@cloudera.org>]

Alex Behm has posted comments on this change.

Change subject: IMPALA-5377: Impala may crash if given a fragment instance while restarting
......................................................................


Patch Set 1:

(1 comment)

I investigated whether there's an easy way to test this, and I tend to agree with Henry.

http://gerrit.cloudera.org:8080/#/c/7036/1/be/src/service/impalad-main.cc
File be/src/service/impalad-main.cc:

Line 100:   ABORT_IF_ERROR(be_server->Start());
Add comment and/or DCHECK explaining these need to come after StartServices().


-- 
To view, visit http://gerrit.cloudera.org:8080/7036
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I1d53b36304cb86c43e110e10cf76a39976ae3bd5
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Henry Robinson <he...@cloudera.com>
Gerrit-Reviewer: Alex Behm <al...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-HasComments: Yes