You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@camel.apache.org by "Freeman Yue Fang (Jira)" <ji...@apache.org> on 2020/10/22 16:06:00 UTC

[jira] [Commented] (CAMEL-15738) camel-fastjson|camel-fhir|camel-gson|camel-jackson|camel-jacksonxml|camel-jaxb|camel-xstream doc mismatch the value in src code

    [ https://issues.apache.org/jira/browse/CAMEL-15738?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17219130#comment-17219130 ] 

Freeman Yue Fang commented on CAMEL-15738:
------------------------------------------

I got to know that the doc is auto-generated from code.

We have a bunch of dataformats have this property,  but expected different default values, please see the list here
{code}
./camel-gson/src/main/java/org/apache/camel/component/gson/GsonDataFormat.java:    private boolean contentTypeHeader = true;
./camel-protobuf/src/main/java/org/apache/camel/dataformat/protobuf/ProtobufDataFormat.java:    private boolean contentTypeHeader;
./camel-xstream/src/main/java/org/apache/camel/dataformat/xstream/AbstractXStreamWrapper.java:    private boolean contentTypeHeader = true;
./camel-jacksonxml/src/main/java/org/apache/camel/component/jacksonxml/JacksonXMLDataFormat.java:    private boolean contentTypeHeader = true;
./camel-jackson/src/main/java/org/apache/camel/component/jackson/JacksonDataFormat.java:    private boolean contentTypeHeader = true;
./camel-castor/src/main/java/org/apache/camel/dataformat/castor/AbstractCastorDataFormat.java:    private boolean contentTypeHeader = true;
./camel-thrift/src/main/java/org/apache/camel/dataformat/thrift/ThriftDataFormat.java:    private boolean contentTypeHeader;
./camel-jaxb/src/main/java/org/apache/camel/converter/jaxb/JaxbDataFormat.java:    private boolean contentTypeHeader = true;
./camel-xmlbeans/src/main/java/org/apache/camel/converter/xmlbeans/XmlBeansDataFormat.java:    private boolean contentTypeHeader = true;
./camel-fhir/camel-fhir-component/src/main/java/org/apache/camel/component/fhir/FhirDataFormat.java:    private boolean contentTypeHeader = true;
./camel-jibx/src/main/java/org/apache/camel/dataformat/jibx/JibxDataFormat.java:    private boolean contentTypeHeader = true;
./camel-fastjson/src/main/java/org/apache/camel/component/fastjson/FastjsonDataFormat.java:    private boolean contentTypeHeader = true;
{code}
Seems this contentTypeHeader is from [here|https://github.com/apache/camel/blob/master/core/camel-core-engine/src/main/java/org/apache/camel/model/DataFormatDefinition.java#L42]

How to handle this case if different dataformats expect different default value? [~acosentino]?

Thanks!
Freeman

> camel-fastjson|camel-fhir|camel-gson|camel-jackson|camel-jacksonxml|camel-jaxb|camel-xstream doc mismatch the value in src code
> -------------------------------------------------------------------------------------------------------------------------------
>
>                 Key: CAMEL-15738
>                 URL: https://issues.apache.org/jira/browse/CAMEL-15738
>             Project: Camel
>          Issue Type: Bug
>          Components: documentation
>            Reporter: Freeman Yue Fang
>            Assignee: Freeman Yue Fang
>            Priority: Major
>
> the default value for contentTypeHeader is true in src code, while it's false in the doc



--
This message was sent by Atlassian Jira
(v8.3.4#803005)