You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "WillAyd (via GitHub)" <gi...@apache.org> on 2025/09/12 18:26:27 UTC
[PR] GH-47554: [C++] Fix Meson Parquet symbol visibility issues [arrow]
WillAyd opened a new pull request, #47556:
URL: https://github.com/apache/arrow/pull/47556
### Rationale for this change
This fixes symbol export visibility issues with the Parquet option enabled
### What changes are included in this PR?
Updates to the Meson configuration, and one definition to get symbol exports to work
### Are these changes tested?
Yes
### Are there any user-facing changes?
No
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-47554: [C++] Fix Meson Parquet symbol visibility issues [arrow]
Posted by "conbench-apache-arrow[bot] (via GitHub)" <gi...@apache.org>.
conbench-apache-arrow[bot] commented on PR #47556:
URL: https://github.com/apache/arrow/pull/47556#issuecomment-3289518904
After merging your PR, Conbench analyzed the 4 benchmarking runs that have been run so far on merge-commit 814537433f09b58ebe68b820f66edd954807b2d5.
There weren't enough matching historic benchmark results to make a call on whether there were regressions.
The [full Conbench report](https://github.com/apache/arrow/runs/50330543472) has more details.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-47554: [C++] Fix Meson Parquet symbol visibility issues [arrow]
Posted by "kou (via GitHub)" <gi...@apache.org>.
kou merged PR #47556:
URL: https://github.com/apache/arrow/pull/47556
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-47554: [C++] Fix Meson Parquet symbol visibility issues [arrow]
Posted by "kou (via GitHub)" <gi...@apache.org>.
kou commented on code in PR #47556:
URL: https://github.com/apache/arrow/pull/47556#discussion_r2346507974
##########
cpp/src/arrow/util/visibility.h:
##########
@@ -67,6 +67,11 @@
# ifndef ARROW_NO_EXPORT
# define ARROW_NO_EXPORT [[gnu::visibility("hidden")]]
# endif
+# if defined(__clang__)
Review Comment:
Could you add a comment for the information?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-47554: [C++] Fix Meson Parquet symbol visibility issues [arrow]
Posted by "WillAyd (via GitHub)" <gi...@apache.org>.
WillAyd commented on code in PR #47556:
URL: https://github.com/apache/arrow/pull/47556#discussion_r2345322880
##########
cpp/src/arrow/util/visibility.h:
##########
@@ -67,6 +67,11 @@
# ifndef ARROW_NO_EXPORT
# define ARROW_NO_EXPORT [[gnu::visibility("hidden")]]
# endif
+# if defined(__clang__)
Review Comment:
This part of the language appears to be vague, and gcc / clang have differing behavior. See https://github.com/llvm/llvm-project/issues/29464 and https://www.open-std.org/jtc1/sc22/wg21/docs/papers/2017/p0537r0.html
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-47554: [C++] Fix Meson Parquet symbol visibility issues [arrow]
Posted by "WillAyd (via GitHub)" <gi...@apache.org>.
WillAyd commented on code in PR #47556:
URL: https://github.com/apache/arrow/pull/47556#discussion_r2346744076
##########
cpp/src/arrow/util/visibility.h:
##########
@@ -67,6 +67,11 @@
# ifndef ARROW_NO_EXPORT
# define ARROW_NO_EXPORT [[gnu::visibility("hidden")]]
# endif
+# if defined(__clang__)
Review Comment:
Done!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-47554: [C++] Fix Meson Parquet symbol visibility issues [arrow]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #47556:
URL: https://github.com/apache/arrow/pull/47556#issuecomment-3286409353
:warning: GitHub issue #47554 **has been automatically assigned in GitHub** to PR creator.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-47554: [C++] Fix Meson Parquet symbol visibility issues [arrow]
Posted by "kou (via GitHub)" <gi...@apache.org>.
kou commented on code in PR #47556:
URL: https://github.com/apache/arrow/pull/47556#discussion_r2346507974
##########
cpp/src/arrow/util/visibility.h:
##########
@@ -67,6 +67,11 @@
# ifndef ARROW_NO_EXPORT
# define ARROW_NO_EXPORT [[gnu::visibility("hidden")]]
# endif
+# if defined(__clang__)
Review Comment:
Could you add the information as a comment?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org