You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cordova.apache.org by dblotsky <gi...@git.apache.org> on 2015/09/30 04:42:35 UTC
[GitHub] cordova-docs pull request: Making Page Index Title Concrete
GitHub user dblotsky opened a pull request:
https://github.com/apache/cordova-docs/pull/365
Making Page Index Title Concrete
Removing the JS that sets the page index title, and instead setting the `title` attribute in the file's front matter.
### Justification
It might seem like it was possible to just use `page.keyword_index_text`, but apparently Jekyll does not work this way. Variables propagate up, but _not down_. The following example illustrates this:
_\_layouts/base.html_
---
star: sun
---
base sees: {{ page.star }} {{ page.planet }}
{{ content }}
_article.html_
---
layout: base
planet: earth
---
article sees: {{ page.star }} {{ page.planet }}
Rendering _article.html_ will yield:
base sees: sun earth
article sees: earth
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/MSOpenTech/cordova-docs cordova-website-index-title
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cordova-docs/pull/365.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #365
----
commit d28333cc0470db40466e051700220b8b603d692b
Author: Dmitry Blotsky <dm...@gmail.com>
Date: 2015-09-30T01:14:53Z
Making page index title a part of the front matter.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-docs pull request: Making Page Index Title Concrete
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/cordova-docs/pull/365
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org