You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pdfbox.apache.org by ti...@apache.org on 2023/03/11 12:00:50 UTC

svn commit: r1908281 - /pdfbox/branches/2.0/fontbox/src/main/java/org/apache/fontbox/cff/Type2CharString.java

Author: tilman
Date: Sat Mar 11 12:00:50 2023
New Revision: 1908281

URL: http://svn.apache.org/viewvc?rev=1908281&view=rev
Log:
PDFBOX-4892: optimize, as suggested by valerybokov

Modified:
    pdfbox/branches/2.0/fontbox/src/main/java/org/apache/fontbox/cff/Type2CharString.java

Modified: pdfbox/branches/2.0/fontbox/src/main/java/org/apache/fontbox/cff/Type2CharString.java
URL: http://svn.apache.org/viewvc/pdfbox/branches/2.0/fontbox/src/main/java/org/apache/fontbox/cff/Type2CharString.java?rev=1908281&r1=1908280&r2=1908281&view=diff
==============================================================================
--- pdfbox/branches/2.0/fontbox/src/main/java/org/apache/fontbox/cff/Type2CharString.java (original)
+++ pdfbox/branches/2.0/fontbox/src/main/java/org/apache/fontbox/cff/Type2CharString.java Sat Mar 11 12:00:50 2023
@@ -204,9 +204,14 @@ public class Type2CharString extends Typ
                 dy += numbers.get(i * 2 + 1).intValue();
             }
             List<Number> first = numbers.subList(0, 6);
-            List<Number> second = Arrays.asList(numbers.get(6), numbers.get(7), numbers.get(8), 
-                    numbers.get(9), (Math.abs(dx) > Math.abs(dy) ? numbers.get(10) : -dx), 
-                    (Math.abs(dx) > Math.abs(dy) ? -dy : numbers.get(10)));
+            boolean dxIsBigger = Math.abs(dx) > Math.abs(dy);
+            List<Number> second = Arrays.asList(
+                    numbers.get(6), 
+                    numbers.get(7), 
+                    numbers.get(8), 
+                    numbers.get(9),
+                    (dxIsBigger ? numbers.get(10) : -dx), 
+                    (dxIsBigger ? -dy : numbers.get(10)));
             addCommandList(Arrays.asList(first, second), new CharStringCommand(8));
         }
         else if ("hstemhm".equals(name))