You are viewing a plain text version of this content. The canonical link for it is here.
Posted to test-dev@httpd.apache.org by "Philippe M. Chiasson" <go...@cpan.org> on 2003/11/26 02:12:55 UTC
Re: [Patch] Handle RedHat style Include
conf.d/*.conf default configuration
On Tue, 2003-11-25 at 16:08, Stas Bekman wrote:
> Philippe M. Chiasson wrote:
> [...]
> >>+1 after doing a proper indentation ;) please get rid of those tabs! and see
> >>below:
> >
> >
> > Sorry, millions of apologies, my editor popped on me ;-(
>
> And it's still off by one in your new patch... have you considered getting a
> decent editor? ;)
I don't want to even start thinking about Emacs dude ;-) I prefer to put
the blame on me, not my editor, sorry ;-)
> > if ($directive eq "Include") {
> > - my $include = $self->server_file_rel2abs($_);
> > - $self->inherit_config_file_or_directory($include);
> > + foreach my $include (glob($self->server_file_rel2abs($_))) {
> > + $self->inherit_config_file_or_directory($include);
> ^^^
> > + }
> > }
>
> other than that, +1. ;)
Changed and comitted then ;-)
>
> __________________________________________________________________
> Stas Bekman JAm_pH ------> Just Another mod_perl Hacker
> http://stason.org/ mod_perl Guide ---> http://perl.apache.org
> mailto:stas@stason.org http://use.perl.org http://apacheweek.com
> http://modperlbook.org http://apache.org http://ticketmaster.com
--
--------------------------------------------------------------------------------
Philippe M. Chiasson /gozer\@(cpan|ectoplasm)\.org/ 88C3A5A5 (122FF51B/C634E37B)
http://gozer.ectoplasm.org/ F9BF E0C2 480E 7680 1AE5 3631 CB32 A107 88C3 A5A5
Q: It is impossible to make anything foolproof because fools are so ingenious.
perl -e'$$=\${gozer};{$_=unpack(P7,pack(L,$$));/^JAm_pH\n$/&&print||$$++&&redo}'
Re: [Patch] Handle RedHat style
Include conf.d/*.conf default configuration
Posted by "Philippe M. Chiasson" <go...@cpan.org>.
On Tue, 2003-11-25 at 18:05, Stas Bekman wrote:
> Philippe M. Chiasson wrote:
>
> >>And it's still off by one in your new patch... have you considered getting a
> >>decent editor? ;)
> >
> >
> > I don't want to even start thinking about Emacs dude ;-) I prefer to put
> > the blame on me, not my editor, sorry ;-)
>
> where did you see me mention emacs, dude? ;)
I just know ;-)
> Both emacs and vi settings are given here:
> http://perl.apache.org/docs/2.0/devel/core/coding_style.html#Coding_Style_Guide
>
> > Changed and comitted then ;-)
>
> cool, also please add an entry to Changes, as this is an important "bug" fix
> for users to know about.
Done!
> __________________________________________________________________
> Stas Bekman JAm_pH ------> Just Another mod_perl Hacker
> http://stason.org/ mod_perl Guide ---> http://perl.apache.org
> mailto:stas@stason.org http://use.perl.org http://apacheweek.com
> http://modperlbook.org http://apache.org http://ticketmaster.com
--
--------------------------------------------------------------------------------
Philippe M. Chiasson /gozer\@(cpan|ectoplasm)\.org/ 88C3A5A5 (122FF51B/C634E37B)
http://gozer.ectoplasm.org/ F9BF E0C2 480E 7680 1AE5 3631 CB32 A107 88C3 A5A5
Q: It is impossible to make anything foolproof because fools are so ingenious.
perl -e'$$=\${gozer};{$_=unpack(P7,pack(L,$$));/^JAm_pH\n$/&&print||$$++&&redo}'
Re: [Patch] Handle RedHat style Include conf.d/*.conf default configuration
Posted by Stas Bekman <st...@stason.org>.
Philippe M. Chiasson wrote:
>>And it's still off by one in your new patch... have you considered getting a
>>decent editor? ;)
>
>
> I don't want to even start thinking about Emacs dude ;-) I prefer to put
> the blame on me, not my editor, sorry ;-)
where did you see me mention emacs, dude? ;)
Both emacs and vi settings are given here:
http://perl.apache.org/docs/2.0/devel/core/coding_style.html#Coding_Style_Guide
> Changed and comitted then ;-)
cool, also please add an entry to Changes, as this is an important "bug" fix
for users to know about.
__________________________________________________________________
Stas Bekman JAm_pH ------> Just Another mod_perl Hacker
http://stason.org/ mod_perl Guide ---> http://perl.apache.org
mailto:stas@stason.org http://use.perl.org http://apacheweek.com
http://modperlbook.org http://apache.org http://ticketmaster.com