You are viewing a plain text version of this content. The canonical link for it is here.
Posted to java-dev@axis.apache.org by Sagara Gunathunga <sa...@gmail.com> on 2011/10/19 11:08:39 UTC
Move SSLProtocolSocketFactory to HTTP transport module.
Hi devs,
Axis2 kernel has an implementation class of
org.apache.commons.httpclient.protocol.SecureProtocolSocketFactory[1]
called SSLProtocolSocketFactory[2]. I couldn't find any reference or
usage of this class within Axis2 myself. I manged to build both Axis2
trunk and Rampart trunks without this class but due to lack of test
coverage I don't like to make any conclusion with build results for
safe side I would like to move this class into transport/http module
from kernel.
This is a required thing to get rid of HttpClient dependency on Axis2
kernel . Any thoughts ? or any better idea ?
[1] - http://hc.apache.org/httpclient-3.x/apidocs/org/apache/commons/httpclient/protocol/SecureProtocolSocketFactory.html
[2] - http://svn.apache.org/repos/asf/axis/axis2/java/core/trunk/modules/kernel/src/org/apache/axis2/java/security/SSLProtocolSocketFactory.java
Thanks !
--
Sagara Gunathunga
Blog - http://ssagara.blogspot.com
Web - http://people.apache.org/~sagara/
LinkedIn - http://www.linkedin.com/in/ssagara
---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@axis.apache.org
For additional commands, e-mail: java-dev-help@axis.apache.org
Re: Move SSLProtocolSocketFactory to HTTP transport module.
Posted by Andreas Veithen <an...@gmail.com>.
On Wed, Oct 19, 2011 at 21:25, Sagara Gunathunga
<sa...@gmail.com> wrote:
> On Thu, Oct 20, 2011 at 12:11 AM, Andreas Veithen
> <an...@gmail.com> wrote:
>> Yes, I think that this class should be moved to the HTTP transport.
>> Note that the usage of that class is actually documented in the
>> Javadoc ... of the TrustAllTrustManager class.
>>
>> The only thing is that in order to make the split-package problem
>> worse (AXIS2-4311), we need to move it to a different package as well.
>
> Noted.
>
> BTW don't you think that we need to address AXIS2-4311 for next major release ?
Definitely. I recently solved AXIS2-4902, and AXIS2-4311 would be the
next thing in order to address the problems of OSGi integration.
> Thanks !
>
>>
>> Andreas
>>
>> On Wed, Oct 19, 2011 at 11:08, Sagara Gunathunga
>> <sa...@gmail.com> wrote:
>>> Hi devs,
>>>
>>> Axis2 kernel has an implementation class of
>>> org.apache.commons.httpclient.protocol.SecureProtocolSocketFactory[1]
>>> called SSLProtocolSocketFactory[2]. I couldn't find any reference or
>>> usage of this class within Axis2 myself. I manged to build both Axis2
>>> trunk and Rampart trunks without this class but due to lack of test
>>> coverage I don't like to make any conclusion with build results for
>>> safe side I would like to move this class into transport/http module
>>> from kernel.
>>>
>>> This is a required thing to get rid of HttpClient dependency on Axis2
>>> kernel . Any thoughts ? or any better idea ?
>>>
>>> [1] - http://hc.apache.org/httpclient-3.x/apidocs/org/apache/commons/httpclient/protocol/SecureProtocolSocketFactory.html
>>> [2] - http://svn.apache.org/repos/asf/axis/axis2/java/core/trunk/modules/kernel/src/org/apache/axis2/java/security/SSLProtocolSocketFactory.java
>>>
>>> Thanks !
>>>
>>> --
>>> Sagara Gunathunga
>>>
>>> Blog - http://ssagara.blogspot.com
>>> Web - http://people.apache.org/~sagara/
>>> LinkedIn - http://www.linkedin.com/in/ssagara
>>>
>>> ---------------------------------------------------------------------
>>> To unsubscribe, e-mail: java-dev-unsubscribe@axis.apache.org
>>> For additional commands, e-mail: java-dev-help@axis.apache.org
>>>
>>>
>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: java-dev-unsubscribe@axis.apache.org
>> For additional commands, e-mail: java-dev-help@axis.apache.org
>>
>>
>
>
>
> --
> Sagara Gunathunga
>
> Blog - http://ssagara.blogspot.com
> Web - http://people.apache.org/~sagara/
> LinkedIn - http://www.linkedin.com/in/ssagara
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: java-dev-unsubscribe@axis.apache.org
> For additional commands, e-mail: java-dev-help@axis.apache.org
>
>
---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@axis.apache.org
For additional commands, e-mail: java-dev-help@axis.apache.org
Re: Move SSLProtocolSocketFactory to HTTP transport module.
Posted by Sagara Gunathunga <sa...@gmail.com>.
On Thu, Oct 20, 2011 at 12:11 AM, Andreas Veithen
<an...@gmail.com> wrote:
> Yes, I think that this class should be moved to the HTTP transport.
> Note that the usage of that class is actually documented in the
> Javadoc ... of the TrustAllTrustManager class.
>
> The only thing is that in order to make the split-package problem
> worse (AXIS2-4311), we need to move it to a different package as well.
Noted.
BTW don't you think that we need to address AXIS2-4311 for next major release ?
Thanks !
>
> Andreas
>
> On Wed, Oct 19, 2011 at 11:08, Sagara Gunathunga
> <sa...@gmail.com> wrote:
>> Hi devs,
>>
>> Axis2 kernel has an implementation class of
>> org.apache.commons.httpclient.protocol.SecureProtocolSocketFactory[1]
>> called SSLProtocolSocketFactory[2]. I couldn't find any reference or
>> usage of this class within Axis2 myself. I manged to build both Axis2
>> trunk and Rampart trunks without this class but due to lack of test
>> coverage I don't like to make any conclusion with build results for
>> safe side I would like to move this class into transport/http module
>> from kernel.
>>
>> This is a required thing to get rid of HttpClient dependency on Axis2
>> kernel . Any thoughts ? or any better idea ?
>>
>> [1] - http://hc.apache.org/httpclient-3.x/apidocs/org/apache/commons/httpclient/protocol/SecureProtocolSocketFactory.html
>> [2] - http://svn.apache.org/repos/asf/axis/axis2/java/core/trunk/modules/kernel/src/org/apache/axis2/java/security/SSLProtocolSocketFactory.java
>>
>> Thanks !
>>
>> --
>> Sagara Gunathunga
>>
>> Blog - http://ssagara.blogspot.com
>> Web - http://people.apache.org/~sagara/
>> LinkedIn - http://www.linkedin.com/in/ssagara
>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: java-dev-unsubscribe@axis.apache.org
>> For additional commands, e-mail: java-dev-help@axis.apache.org
>>
>>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: java-dev-unsubscribe@axis.apache.org
> For additional commands, e-mail: java-dev-help@axis.apache.org
>
>
--
Sagara Gunathunga
Blog - http://ssagara.blogspot.com
Web - http://people.apache.org/~sagara/
LinkedIn - http://www.linkedin.com/in/ssagara
---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@axis.apache.org
For additional commands, e-mail: java-dev-help@axis.apache.org
Re: Move SSLProtocolSocketFactory to HTTP transport module.
Posted by Andreas Veithen <an...@gmail.com>.
Yes, I think that this class should be moved to the HTTP transport.
Note that the usage of that class is actually documented in the
Javadoc ... of the TrustAllTrustManager class.
The only thing is that in order to make the split-package problem
worse (AXIS2-4311), we need to move it to a different package as well.
Andreas
On Wed, Oct 19, 2011 at 11:08, Sagara Gunathunga
<sa...@gmail.com> wrote:
> Hi devs,
>
> Axis2 kernel has an implementation class of
> org.apache.commons.httpclient.protocol.SecureProtocolSocketFactory[1]
> called SSLProtocolSocketFactory[2]. I couldn't find any reference or
> usage of this class within Axis2 myself. I manged to build both Axis2
> trunk and Rampart trunks without this class but due to lack of test
> coverage I don't like to make any conclusion with build results for
> safe side I would like to move this class into transport/http module
> from kernel.
>
> This is a required thing to get rid of HttpClient dependency on Axis2
> kernel . Any thoughts ? or any better idea ?
>
> [1] - http://hc.apache.org/httpclient-3.x/apidocs/org/apache/commons/httpclient/protocol/SecureProtocolSocketFactory.html
> [2] - http://svn.apache.org/repos/asf/axis/axis2/java/core/trunk/modules/kernel/src/org/apache/axis2/java/security/SSLProtocolSocketFactory.java
>
> Thanks !
>
> --
> Sagara Gunathunga
>
> Blog - http://ssagara.blogspot.com
> Web - http://people.apache.org/~sagara/
> LinkedIn - http://www.linkedin.com/in/ssagara
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: java-dev-unsubscribe@axis.apache.org
> For additional commands, e-mail: java-dev-help@axis.apache.org
>
>
---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@axis.apache.org
For additional commands, e-mail: java-dev-help@axis.apache.org