You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@impala.apache.org by "Anurag Mantripragada (Code Review)" <ge...@cloudera.org> on 2019/04/02 05:30:42 UTC

[Impala-ASF-CR] IMPALA-4865: Reject Expr Rewrite When Appropriate

Anurag Mantripragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/12814 )

Change subject: IMPALA-4865: Reject Expr Rewrite When Appropriate
......................................................................


Patch Set 5:

Welcome to the community. Congratulations on your first change. Just a newbie comment: We use line width of 90. If you use an IDE you can configure it to wrap at 90. This will prevent the bot from giving you style related warnings.

You can find Impala style guide here: https://cwiki.apache.org/confluence/pages/viewpage.action?pageId=65868536
It is mostly for C++ code, but relevant for Java as well.


-- 
To view, visit http://gerrit.cloudera.org:8080/12814
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I8b078113ccc1aa49b0cea0c86dff2e02e1dd0e23
Gerrit-Change-Number: 12814
Gerrit-PatchSet: 5
Gerrit-Owner: Fang-Yu Rao <fa...@cloudera.com>
Gerrit-Reviewer: Anurag Mantripragada <an...@cloudera.com>
Gerrit-Reviewer: Fang-Yu Rao <fa...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Paul Rogers <pr...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Tue, 02 Apr 2019 05:30:42 +0000
Gerrit-HasComments: No