You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Andrew Wong (Code Review)" <ge...@cloudera.org> on 2018/08/07 16:24:41 UTC
[kudu-CR] wip consensus: add RPC to replicate a NO OP
Andrew Wong has uploaded this change for review. ( http://gerrit.cloudera.org:8080/11143
Change subject: wip consensus: add RPC to replicate a NO_OP
......................................................................
wip consensus: add RPC to replicate a NO_OP
This patch adds an RPC to replicate a NO_OP message. Unlike NO_OPs that
get sent following leader elections, these NO_OPs do not have any
guarantees regarding the monotonicity of their timestamps with respect
to other operations.
In addition to being a nice tool to check that consensus is running on a
given server for a given tablet, this endpoint is useful in stressing
the assignment of timestamps for non-txn operations. Pinging consensus
on a leader will replicate
It's important to be able to determine whether or not a NO_OP message
was created using this endpoint directly, vs through the normal flow of
Raft's election algorithm, as timestamps assigned in the former are
serialized with respect to writes in the term the NO_OP was sent. As
such, a field has been added to the NoOpRequestPB indicating whether the
NO_OP was sent via this RPC or not.
WIP: would like to add more targetted testing
Change-Id: If98292503dc81cdd1290f1d96d8b4229ae56224f
---
M src/kudu/consensus/consensus.proto
M src/kudu/consensus/raft_consensus.cc
M src/kudu/consensus/raft_consensus.h
M src/kudu/tserver/tablet_service.cc
M src/kudu/tserver/tablet_service.h
5 files changed, 101 insertions(+), 21 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/43/11143/1
--
To view, visit http://gerrit.cloudera.org:8080/11143
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: If98292503dc81cdd1290f1d96d8b4229ae56224f
Gerrit-Change-Number: 11143
Gerrit-PatchSet: 1
Gerrit-Owner: Andrew Wong <aw...@cloudera.com>
[kudu-CR] wip consensus: add RPC to replicate a NO OP
Posted by "Andrew Wong (Code Review)" <ge...@cloudera.org>.
Hello Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/11143
to look at the new patch set (#2).
Change subject: wip consensus: add RPC to replicate a NO_OP
......................................................................
wip consensus: add RPC to replicate a NO_OP
This patch adds an RPC to replicate a NO_OP message. Unlike NO_OPs that
get sent following leader elections, these NO_OPs do not have any
guarantees regarding the monotonicity of their timestamps with respect
to other operations.
In addition to being a nice tool to check that consensus is running on a
given server for a given tablet, this endpoint is useful in stressing
the assignment of timestamps for non-txn operations. Pinging consensus
on a leader will replicate
It's important to be able to determine whether or not a NO_OP message
was created using this endpoint directly, vs through the normal flow of
Raft's election algorithm, as timestamps assigned in the former are
serialized with respect to writes in the term the NO_OP was sent. As
such, a field has been added to the NoOpRequestPB indicating whether the
NO_OP was sent via this RPC or not.
WIP: would like to add more targetted testing
Change-Id: If98292503dc81cdd1290f1d96d8b4229ae56224f
---
M src/kudu/consensus/consensus.proto
M src/kudu/consensus/raft_consensus.cc
M src/kudu/consensus/raft_consensus.h
M src/kudu/tserver/tablet_service.cc
M src/kudu/tserver/tablet_service.h
5 files changed, 95 insertions(+), 21 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/43/11143/2
--
To view, visit http://gerrit.cloudera.org:8080/11143
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: If98292503dc81cdd1290f1d96d8b4229ae56224f
Gerrit-Change-Number: 11143
Gerrit-PatchSet: 2
Gerrit-Owner: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
[kudu-CR] wip consensus: add RPC to replicate a NO OP
Posted by "Andrew Wong (Code Review)" <ge...@cloudera.org>.
Andrew Wong has abandoned this change. ( http://gerrit.cloudera.org:8080/11143 )
Change subject: wip consensus: add RPC to replicate a NO_OP
......................................................................
Abandoned
probably not useful in its current form
--
To view, visit http://gerrit.cloudera.org:8080/11143
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: abandon
Gerrit-Change-Id: If98292503dc81cdd1290f1d96d8b4229ae56224f
Gerrit-Change-Number: 11143
Gerrit-PatchSet: 2
Gerrit-Owner: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)