[GitHub] [iotdb] mychaow commented on a change in pull request #3292: [IOTDB-1407] Filtering time series based on tags query fails Occasion…

[GitBox <gi...@apache.org>]

mychaow commented on a change in pull request #3292:
URL: https://github.com/apache/iotdb/pull/3292#discussion_r643636632



##########
File path: cluster/src/main/java/org/apache/iotdb/cluster/metadata/CMManager.java
##########
@@ -1717,7 +1726,7 @@ public MNode getMNode(MNode deviceMNode, String measurementName) {
               () -> {
                 try {
                   showTimeseries(group, plan, resultSet, context);
-                } catch (CheckConsistencyException e) {
+                } catch (CheckConsistencyException | MetadataException e) {

Review comment:
       LGTM. But there is one minor issues.  This will ignore some errors, resulting in query results have problems. Like we execute  show timeseries, some data group failed with other errors exclude tag not found, we will return result. 




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org