You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@skywalking.apache.org by GitBox <gi...@apache.org> on 2019/05/06 07:44:46 UTC

[GitHub] [skywalking] IanCao commented on a change in pull request #2605: Support span#error in toolkit

IanCao commented on a change in pull request #2605: Support span#error in toolkit
URL: https://github.com/apache/skywalking/pull/2605#discussion_r281087193
 
 

 ##########
 File path: apm-sniffer/apm-toolkit-activation/apm-toolkit-trace-activation/src/main/java/org/apache/skywalking/apm/toolkit/activation/trace/ActiveSpanActivation.java
 ##########
 @@ -35,11 +35,13 @@
  *
  * @author zhangxin
  */
-public class ActiveSpanTagActivation extends ClassStaticMethodsEnhancePluginDefine {
+public class ActiveSpanActivation extends ClassStaticMethodsEnhancePluginDefine {
 
 Review comment:
   because  ActiveSpan contains only one tag before, but now ActiveSpan contains two method .so i think ActiveSpanActivation is better, what's ur idea?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services