You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@subversion.apache.org by ju...@apache.org on 2015/11/04 18:57:50 UTC
svn commit: r1712600 - /subversion/trunk/subversion/include/svn_fs.h
Author: julianfoad
Date: Wed Nov 4 17:57:50 2015
New Revision: 1712600
URL: http://svn.apache.org/viewvc?rev=1712600&view=rev
Log:
* subversion/include/svn_fs.h
(svn_fs_txns group): Remove an obsolete comment about transaction names.
It described a naming scheme introduced in r865504 and removed in r865943.
(Committed previously as ^/subversion/branches/move-tracking-2@1607290, but
unrelated to that branch.)
Modified:
subversion/trunk/subversion/include/svn_fs.h
Modified: subversion/trunk/subversion/include/svn_fs.h
URL: http://svn.apache.org/viewvc/subversion/trunk/subversion/include/svn_fs.h?rev=1712600&r1=1712599&r2=1712600&view=diff
==============================================================================
--- subversion/trunk/subversion/include/svn_fs.h (original)
+++ subversion/trunk/subversion/include/svn_fs.h Wed Nov 4 17:57:50 2015
@@ -1076,15 +1076,12 @@ svn_fs_unparse_id(const svn_fs_id_t *id,
* set.
*
* The Subversion filesystem will make a best effort to not reuse
- * transaction names. The Berkeley DB backend generates transaction
- * names using a sequence, or a counter, which is stored in the BDB
+ * transaction names. The BDB and FSFS backends generate transaction
+ * names using a sequence, or a counter, which is stored in the
* database. Each new transaction increments the counter. The
* current value of the counter is not serialized into a filesystem
* dump file, so dumping and restoring the repository will reset the
- * sequence and reuse transaction names. The FSFS backend generates a
- * transaction name using the hostname, process ID and current time in
- * microseconds since 00:00:00 January 1, 1970 UTC. So it is
- * extremely unlikely that a transaction name will be reused.
+ * sequence and reuse transaction names.
*
* @defgroup svn_fs_txns Filesystem transactions
* @{
Re: svn commit: r1712600 - /subversion/trunk/subversion/include/svn_fs.h
Posted by Julian Foad <ju...@gmail.com>.
Bert Huijben wrote:
>> Author: julianfoad
>> URL: http://svn.apache.org/viewvc?rev=1712600&view=rev
>> Log:
>> * subversion/include/svn_fs.h
>> (svn_fs_txns group): Remove an obsolete comment about transaction names.
>> It described a naming scheme introduced in r865504 and removed in r865943.
[...]
>> *
>> * The Subversion filesystem will make a best effort to not reuse
>> - * transaction names. The Berkeley DB backend generates transaction
>> - * names using a sequence, or a counter, which is stored in the BDB
>> + * transaction names. The BDB and FSFS backends generate transaction
>> + * names using a sequence, or a counter, which is stored in the
>> * database. Each new transaction increments the counter. The
>> * current value of the counter is not serialized into a filesystem
>> * dump file, so dumping and restoring the repository will reset the
>> - * sequence and reuse transaction names. The FSFS backend generates a
>> - * transaction name using the hostname, process ID and current time in
>> - * microseconds since 00:00:00 January 1, 1970 UTC. So it is
>> - * extremely unlikely that a transaction name will be reused.
>> + * sequence and reuse transaction names.
>
> I would have said it 'may' reuse transaction names.
>
> I don't think we promise that they will actually be reused or not. And perhaps the format may change again in the future.
Good point. r1712828.
- Julian
- Julian
Re: svn commit: r1712600 - /subversion/trunk/subversion/include/svn_fs.h
Posted by Julian Foad <ju...@gmail.com>.
Bert Huijben wrote:
>> Author: julianfoad
>> URL: http://svn.apache.org/viewvc?rev=1712600&view=rev
>> Log:
>> * subversion/include/svn_fs.h
>> (svn_fs_txns group): Remove an obsolete comment about transaction names.
>> It described a naming scheme introduced in r865504 and removed in r865943.
[...]
>> *
>> * The Subversion filesystem will make a best effort to not reuse
>> - * transaction names. The Berkeley DB backend generates transaction
>> - * names using a sequence, or a counter, which is stored in the BDB
>> + * transaction names. The BDB and FSFS backends generate transaction
>> + * names using a sequence, or a counter, which is stored in the
>> * database. Each new transaction increments the counter. The
>> * current value of the counter is not serialized into a filesystem
>> * dump file, so dumping and restoring the repository will reset the
>> - * sequence and reuse transaction names. The FSFS backend generates a
>> - * transaction name using the hostname, process ID and current time in
>> - * microseconds since 00:00:00 January 1, 1970 UTC. So it is
>> - * extremely unlikely that a transaction name will be reused.
>> + * sequence and reuse transaction names.
>
> I would have said it 'may' reuse transaction names.
>
> I don't think we promise that they will actually be reused or not. And perhaps the format may change again in the future.
Good point. r1712828.
- Julian
- Julian
RE: svn commit: r1712600 - /subversion/trunk/subversion/include/svn_fs.h
Posted by Bert Huijben <be...@qqmail.nl>.
> -----Original Message-----
> From: julianfoad@apache.org [mailto:julianfoad@apache.org]
> Sent: woensdag 4 november 2015 18:58
> To: commits@subversion.apache.org
> Subject: svn commit: r1712600 -
> /subversion/trunk/subversion/include/svn_fs.h
>
> Author: julianfoad
> Date: Wed Nov 4 17:57:50 2015
> New Revision: 1712600
>
> URL: http://svn.apache.org/viewvc?rev=1712600&view=rev
> Log:
> * subversion/include/svn_fs.h
> (svn_fs_txns group): Remove an obsolete comment about transaction
> names.
> It described a naming scheme introduced in r865504 and removed in
> r865943.
>
> (Committed previously as ^/subversion/branches/move-tracking-
> 2@1607290, but
> unrelated to that branch.)
>
> Modified:
> subversion/trunk/subversion/include/svn_fs.h
>
> Modified: subversion/trunk/subversion/include/svn_fs.h
> URL:
> http://svn.apache.org/viewvc/subversion/trunk/subversion/include/svn_fs.
> h?rev=1712600&r1=1712599&r2=1712600&view=diff
> ==========================================================
> ====================
> --- subversion/trunk/subversion/include/svn_fs.h (original)
> +++ subversion/trunk/subversion/include/svn_fs.h Wed Nov 4 17:57:50
> 2015
> @@ -1076,15 +1076,12 @@ svn_fs_unparse_id(const svn_fs_id_t *id,
> * set.
> *
> * The Subversion filesystem will make a best effort to not reuse
> - * transaction names. The Berkeley DB backend generates transaction
> - * names using a sequence, or a counter, which is stored in the BDB
> + * transaction names. The BDB and FSFS backends generate transaction
> + * names using a sequence, or a counter, which is stored in the
> * database. Each new transaction increments the counter. The
> * current value of the counter is not serialized into a filesystem
> * dump file, so dumping and restoring the repository will reset the
> - * sequence and reuse transaction names. The FSFS backend generates a
> - * transaction name using the hostname, process ID and current time in
> - * microseconds since 00:00:00 January 1, 1970 UTC. So it is
> - * extremely unlikely that a transaction name will be reused.
> + * sequence and reuse transaction names.
I would have said it 'may' reuse transaction names.
I don't think we promise that they will actually be reused or not. And perhaps the format may change again in the future.
Bert
RE: svn commit: r1712600 - /subversion/trunk/subversion/include/svn_fs.h
Posted by Bert Huijben <be...@qqmail.nl>.
> -----Original Message-----
> From: julianfoad@apache.org [mailto:julianfoad@apache.org]
> Sent: woensdag 4 november 2015 18:58
> To: commits@subversion.apache.org
> Subject: svn commit: r1712600 -
> /subversion/trunk/subversion/include/svn_fs.h
>
> Author: julianfoad
> Date: Wed Nov 4 17:57:50 2015
> New Revision: 1712600
>
> URL: http://svn.apache.org/viewvc?rev=1712600&view=rev
> Log:
> * subversion/include/svn_fs.h
> (svn_fs_txns group): Remove an obsolete comment about transaction
> names.
> It described a naming scheme introduced in r865504 and removed in
> r865943.
>
> (Committed previously as ^/subversion/branches/move-tracking-
> 2@1607290, but
> unrelated to that branch.)
>
> Modified:
> subversion/trunk/subversion/include/svn_fs.h
>
> Modified: subversion/trunk/subversion/include/svn_fs.h
> URL:
> http://svn.apache.org/viewvc/subversion/trunk/subversion/include/svn_fs.
> h?rev=1712600&r1=1712599&r2=1712600&view=diff
> ==========================================================
> ====================
> --- subversion/trunk/subversion/include/svn_fs.h (original)
> +++ subversion/trunk/subversion/include/svn_fs.h Wed Nov 4 17:57:50
> 2015
> @@ -1076,15 +1076,12 @@ svn_fs_unparse_id(const svn_fs_id_t *id,
> * set.
> *
> * The Subversion filesystem will make a best effort to not reuse
> - * transaction names. The Berkeley DB backend generates transaction
> - * names using a sequence, or a counter, which is stored in the BDB
> + * transaction names. The BDB and FSFS backends generate transaction
> + * names using a sequence, or a counter, which is stored in the
> * database. Each new transaction increments the counter. The
> * current value of the counter is not serialized into a filesystem
> * dump file, so dumping and restoring the repository will reset the
> - * sequence and reuse transaction names. The FSFS backend generates a
> - * transaction name using the hostname, process ID and current time in
> - * microseconds since 00:00:00 January 1, 1970 UTC. So it is
> - * extremely unlikely that a transaction name will be reused.
> + * sequence and reuse transaction names.
I would have said it 'may' reuse transaction names.
I don't think we promise that they will actually be reused or not. And perhaps the format may change again in the future.
Bert