You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@activemq.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2018/03/20 11:06:00 UTC

[jira] [Commented] (ARTEMIS-1754) LargeServerMessageImpl.toString() may leak files

    [ https://issues.apache.org/jira/browse/ARTEMIS-1754?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16406140#comment-16406140 ] 

ASF GitHub Bot commented on ARTEMIS-1754:
-----------------------------------------

GitHub user gaohoward opened a pull request:

    https://github.com/apache/activemq-artemis/pull/1959

    ARTEMIS-1754 LargeServerMessageImpl.toString() may leak files

    This overridden method calls getPersistentSize() which may lead
    to open the large file to get the size. Calling it alone will
    cause the file being opened without closing it.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/gaohoward/activemq-artemis g_1754

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/activemq-artemis/pull/1959.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1959
    
----
commit 40fde75d6483b76330292957df7e77313973963a
Author: Howard Gao <ho...@...>
Date:   2018-03-20T11:01:16Z

    ARTEMIS-1754 LargeServerMessageImpl.toString() may leak files
    
    This overridden method calls getPersistentSize() which may lead
    to open the large file to get the size. Calling it alone will
    cause the file being opened without closing it.

----


> LargeServerMessageImpl.toString() may leak files
> ------------------------------------------------
>
>                 Key: ARTEMIS-1754
>                 URL: https://issues.apache.org/jira/browse/ARTEMIS-1754
>             Project: ActiveMQ Artemis
>          Issue Type: Bug
>          Components: Broker
>    Affects Versions: 2.5.0
>            Reporter: Howard Gao
>            Assignee: Howard Gao
>            Priority: Major
>             Fix For: 2.5.1
>
>
> This overridden method calls getPersistentSize() which may lead to open the large file to get the size. Calling it alone will cause the file being opened without closing it.
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)