You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@maven.apache.org by Benjamin Bentmann <be...@udo.edu> on 2009/05/18 07:56:41 UTC
Re: svn commit: r775789 - in /maven/resources/trunk/apache-source-release-assembly-descriptor:
./ pom.xml src/ src/main/ src/main/resources/ src/main/resources/assemblies/
src/main/resources/assemblies/source-release.xml
Hi Brian,
> Author: brianf
> Date: Mon May 18 01:15:18 2009
> New Revision: 775789
>
> URL: http://svn.apache.org/viewvc?rev=775789&view=rev
> Log:
> add new component to hold the asf specific source descriptor
>
> +<assembly>
> + <id>source-release</id>
> + <formats>
> + <format>tar.gz</format>
> + <format>zip</format>
> + </formats>
> + <fileSets>
> + <fileSet>
> + <directory>${project.basedir}</directory>
> + <useDefaultExcludes>true</useDefaultExcludes>
> + <excludes>
> + <exclude>**/${project.build.directory}/**</exclude>
> + </excludes>
Is this <exclude> working reliably? AFAIK, include/exclude patterns are
usually relative to the fileset's base directory but
${project.build.directory} could resolve to an absolute path, couldn't it?
Benjamin
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
Re: svn commit: r775789 - in /maven/resources/trunk/apache-source-release-assembly-descriptor:
./ pom.xml src/ src/main/ src/main/resources/ src/main/resources/assemblies/
src/main/resources/assemblies/source-release.xml
Posted by Brian Fox <br...@infinity.nu>.
That was the bug i mentioned that needs to be fixed first ;-)
The excludes will only work for the current project, not all child projects
if they weren't already clean. Since my intents is to insert this into the
release profile, I should be able to make it work pretty reliably. I'm
concerned about adding **/target/** though since if a child project includes
a target folder somewhere in the src, it would be excluded as well.
On Mon, May 18, 2009 at 9:17 AM, Brett Porter <br...@apache.org> wrote:
>
> On 18/05/2009, at 3:56 PM, Benjamin Bentmann wrote:
>
> Hi Brian,
>>
>> Author: brianf
>>> Date: Mon May 18 01:15:18 2009
>>> New Revision: 775789
>>> URL: http://svn.apache.org/viewvc?rev=775789&view=rev
>>> Log:
>>> add new component to hold the asf specific source descriptor
>>> +<assembly>
>>> + <id>source-release</id>
>>> + <formats>
>>> + <format>tar.gz</format>
>>> + <format>zip</format>
>>> + </formats>
>>> + <fileSets>
>>> + <fileSet>
>>> + <directory>${project.basedir}</directory>
>>> + <useDefaultExcludes>true</useDefaultExcludes>
>>> + <excludes>
>>> + <exclude>**/${project.build.directory}/**</exclude>
>>> + </excludes>
>>>
>>
>> Is this <exclude> working reliably? AFAIK, include/exclude patterns are
>> usually relative to the fileset's base directory but
>> ${project.build.directory} could resolve to an absolute path, couldn't it?
>>
>
>
> I checked with 2.2-beta-3 and it doesn't behave correctly (it is always an
> absolute path), and fails trying to include the tarball itself from target.
> Does it require a more recent assembly plugin change?
>
> - Brett
>
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
> For additional commands, e-mail: dev-help@maven.apache.org
>
>
Re: svn commit: r775789 - in /maven/resources/trunk/apache-source-release-assembly-descriptor: ./ pom.xml src/ src/main/ src/main/resources/ src/main/resources/assemblies/ src/main/resources/assemblies/source-release.xml
Posted by Brett Porter <br...@apache.org>.
On 18/05/2009, at 3:56 PM, Benjamin Bentmann wrote:
> Hi Brian,
>
>> Author: brianf
>> Date: Mon May 18 01:15:18 2009
>> New Revision: 775789
>> URL: http://svn.apache.org/viewvc?rev=775789&view=rev
>> Log:
>> add new component to hold the asf specific source descriptor
>> +<assembly>
>> + <id>source-release</id>
>> + <formats>
>> + <format>tar.gz</format>
>> + <format>zip</format>
>> + </formats>
>> + <fileSets>
>> + <fileSet>
>> + <directory>${project.basedir}</directory>
>> + <useDefaultExcludes>true</useDefaultExcludes>
>> + <excludes>
>> + <exclude>**/${project.build.directory}/**</exclude>
>> + </excludes>
>
> Is this <exclude> working reliably? AFAIK, include/exclude patterns
> are usually relative to the fileset's base directory but $
> {project.build.directory} could resolve to an absolute path,
> couldn't it?
I checked with 2.2-beta-3 and it doesn't behave correctly (it is
always an absolute path), and fails trying to include the tarball
itself from target. Does it require a more recent assembly plugin
change?
- Brett
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org