[jira] [Commented] (FLINK-7068) change BlobService sub-classes for permanent and transient BLOBs

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/FLINK-7068?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16188024#comment-16188024 ] 

ASF GitHub Bot commented on FLINK-7068:
---------------------------------------

Github user tillrohrmann commented on a diff in the pull request:

    https://github.com/apache/flink/pull/4358#discussion_r142129292
  
    --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/blob/BlobClient.java ---
    @@ -120,6 +125,76 @@ public BlobClient(InetSocketAddress serverAddress, Configuration clientConfig) t
     		}
     	}
     
    +	/**
    +	 * Downloads the given BLOB from the given server and stores its contents to a (local) file.
    +	 *
    +	 * <p>Transient BLOB files are deleted after a successful copy of the server's data into the
    +	 * given <tt>localJarFile</tt>.
    +	 *
    +	 * @param jobId
    +	 * 		job ID the BLOB belongs to or <tt>null</tt> if job-unrelated
    +	 * @param blobKey
    +	 * 		BLOB key
    +	 * @param localJarFile
    +	 * 		the local file to write to
    +	 * @param serverAddress
    +	 * 		address of the server to download from
    +	 * @param blobClientConfig
    +	 * 		client configuration for the connection
    +	 * @param numFetchRetries
    +	 * 		number of retries before failing
    +	 *
    +	 * @throws IOException
    +	 * 		if an I/O error occurs during the download
    +	 */
    +	static void downloadFromBlobServer(
    +			@Nullable JobID jobId, BlobKey blobKey, File localJarFile,
    +			InetSocketAddress serverAddress, Configuration blobClientConfig, int numFetchRetries)
    --- End diff --
    
    Wrapping the parameters could be one per line.


> change BlobService sub-classes for permanent and transient BLOBs
> ----------------------------------------------------------------
>
>                 Key: FLINK-7068
>                 URL: https://issues.apache.org/jira/browse/FLINK-7068
>             Project: Flink
>          Issue Type: Sub-task
>          Components: Distributed Coordination, Network
>    Affects Versions: 1.4.0
>            Reporter: Nico Kruber
>            Assignee: Nico Kruber
>
> A {{PermanentBlobStore}} should resemble use cases for BLOBs that are permanently stored for a job's life time (HA and non-HA).
> A {{TransientBlobStore}} should reflect BLOB offloading for logs, RPC, etc. which even does not have to be reflected by files.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)