[GitHub] [hive] ayushtkn commented on a change in pull request #1954: HIVE-24750. Create a single copy task for external tables within default DB location.

[GitBox <gi...@apache.org>]

ayushtkn commented on a change in pull request #1954:
URL: https://github.com/apache/hive/pull/1954#discussion_r581666341



##########
File path: ql/src/java/org/apache/hadoop/hive/ql/exec/repl/ReplExternalTables.java
##########
@@ -180,6 +195,14 @@ void dataLocationDump(Table table, FileList fileList, HiveConf conf)
       }
     }
 
+    void dbLocationDump(String dbName, Path dbLocation, FileList fileList,
+        HiveConf conf) throws Exception {
+      Path fullyQualifiedDataLocation = PathBuilder
+          .fullyQualifiedHDFSUri(dbLocation, FileSystem.get(hiveConf));
+      write(lineFor(dbName, fullyQualifiedDataLocation, hiveConf));

Review comment:
       Nopes, the name isn't used anywhere, it writes to `_external_tables_info` which is anyway going to get deleted




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org