[GitHub] [superset] michael-s-molina edited a comment on pull request #15853: feat(homepage): add more cards and new layout

[GitBox <gi...@apache.org>]

michael-s-molina edited a comment on pull request #15853:
URL: https://github.com/apache/superset/pull/15853#issuecomment-887781088


   @pkdotson @rusackas One thing we can do in a follow-up PR is to get rid of the flick effect that happens when I'm changing tabs.
   
   https://user-images.githubusercontent.com/70410625/127216387-56e41443-c1ae-43e0-ac76-65ddfaf27779.mov
   
   When changing the selected tab I don't expect it to re-render, only to view a loading icon in the content of the tab. If we keep the same height for the tab content in all states (loading, empty, with results), then the flicking effect will disappear.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org