You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ambari.apache.org by Robert Levas <rl...@hortonworks.com> on 2015/02/06 21:40:55 UTC

Review Request 30745: Kerberos: Keytab regeneration not invoked when initiated via API

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30745/
-----------------------------------------------------------

Review request for Ambari, John Speidel and Robert Nettleton.


Bugs: AMBARI-9514
    https://issues.apache.org/jira/browse/AMBARI-9514


Repository: ambari


Description
-------

Fixed error condition by returning the created/updated RequestStageContainer.
Updated unit tests to ensure this is the case


Diffs
-----

  ambari-server/src/main/java/org/apache/ambari/server/controller/KerberosHelper.java 8341826 
  ambari-server/src/test/java/org/apache/ambari/server/controller/KerberosHelperTest.java 5cf15d8 

Diff: https://reviews.apache.org/r/30745/diff/


Testing
-------

Manually tested in test cluster
Updated unit tests

# Jenkins test results
Running org.apache.ambari.server.controller.KerberosHelperTest
Tests run: 18, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 2.555 sec

Ambari server test suite
Tests run: 2657, Failures: 0, Errors: 0, Skipped: 15


[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 01:05 h
[INFO] Finished at: 2015-02-06T20:15:36+00:00
[INFO] Final Memory: 44M/540M
[INFO] ------------------------------------------------------------------------


Thanks,

Robert Levas


Re: Review Request 30745: Kerberos: Keytab regeneration not invoked when initiated via API

Posted by Robert Nettleton <rn...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30745/#review71502
-----------------------------------------------------------

Ship it!


Ship It!

- Robert Nettleton


On Feb. 6, 2015, 8:40 p.m., Robert Levas wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/30745/
> -----------------------------------------------------------
> 
> (Updated Feb. 6, 2015, 8:40 p.m.)
> 
> 
> Review request for Ambari, John Speidel and Robert Nettleton.
> 
> 
> Bugs: AMBARI-9514
>     https://issues.apache.org/jira/browse/AMBARI-9514
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> Fixed error condition by returning the created/updated RequestStageContainer.
> Updated unit tests to ensure this is the case
> 
> 
> Diffs
> -----
> 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/KerberosHelper.java 8341826 
>   ambari-server/src/test/java/org/apache/ambari/server/controller/KerberosHelperTest.java 5cf15d8 
> 
> Diff: https://reviews.apache.org/r/30745/diff/
> 
> 
> Testing
> -------
> 
> Manually tested in test cluster
> Updated unit tests
> 
> # Jenkins test results
> Running org.apache.ambari.server.controller.KerberosHelperTest
> Tests run: 18, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 2.555 sec
> 
> Ambari server test suite
> Tests run: 2657, Failures: 0, Errors: 0, Skipped: 15
> 
> 
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 01:05 h
> [INFO] Finished at: 2015-02-06T20:15:36+00:00
> [INFO] Final Memory: 44M/540M
> [INFO] ------------------------------------------------------------------------
> 
> 
> Thanks,
> 
> Robert Levas
> 
>


Re: Review Request 30745: Kerberos: Keytab regeneration not invoked when initiated via API

Posted by John Speidel <js...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30745/#review71499
-----------------------------------------------------------

Ship it!


Ship It!

- John Speidel


On Feb. 6, 2015, 8:40 p.m., Robert Levas wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/30745/
> -----------------------------------------------------------
> 
> (Updated Feb. 6, 2015, 8:40 p.m.)
> 
> 
> Review request for Ambari, John Speidel and Robert Nettleton.
> 
> 
> Bugs: AMBARI-9514
>     https://issues.apache.org/jira/browse/AMBARI-9514
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> Fixed error condition by returning the created/updated RequestStageContainer.
> Updated unit tests to ensure this is the case
> 
> 
> Diffs
> -----
> 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/KerberosHelper.java 8341826 
>   ambari-server/src/test/java/org/apache/ambari/server/controller/KerberosHelperTest.java 5cf15d8 
> 
> Diff: https://reviews.apache.org/r/30745/diff/
> 
> 
> Testing
> -------
> 
> Manually tested in test cluster
> Updated unit tests
> 
> # Jenkins test results
> Running org.apache.ambari.server.controller.KerberosHelperTest
> Tests run: 18, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 2.555 sec
> 
> Ambari server test suite
> Tests run: 2657, Failures: 0, Errors: 0, Skipped: 15
> 
> 
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 01:05 h
> [INFO] Finished at: 2015-02-06T20:15:36+00:00
> [INFO] Final Memory: 44M/540M
> [INFO] ------------------------------------------------------------------------
> 
> 
> Thanks,
> 
> Robert Levas
> 
>