[GitHub] betodealmeida commented on issue #6719: Adding support for Pinot

[GitBox <gi...@apache.org>]

betodealmeida commented on issue #6719: Adding support for Pinot
URL: https://github.com/apache/incubator-superset/pull/6719#issuecomment-460864553
 
 
   > I decided against creating a PQL string that I then reparse and change under the covers before giving it to Pinot: ***I would like the generated query to be something that the user can take it and directly do a REST query to Pinot and it should work***. It shouldn't be a Pinot-QL dialect that is private to Superset. (emphasis mine)
   
   I see. I think this is a valid design decision. Essentially we need to make a choice:
   
   1. Do we want to show a query that is being sent to the DB API driver and can run in SQL Lab giving the exact same results; or
   2. Do we want to show a query that can be sent to the DB directly without using Superset?
   
   For the Google Spreadsheets connector I went with (1), mainly because the user will never send the SQL to Google Spreadsheets since it only support very basic queries and everything else is done through pre and post processors, so it was an easy decision. For Druid (1) and (2) are identical, so no choice needs to be done.
   
   Ideally the changes should be pushed upstream to Pinot. When I presented the first draft of the Python DB driver they seemed excited and open to improving the SQL parser, so that might be our best option.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org