[GitHub] [jackrabbit-oak] klcodanr commented on a diff in pull request #535: OAK-9740 - Offset / Limit Option

[GitBox <gi...@apache.org>]

klcodanr commented on code in PR #535:
URL: https://github.com/apache/jackrabbit-oak/pull/535#discussion_r842928240


##########
oak-core/src/main/java/org/apache/jackrabbit/oak/query/xpath/Statement.java:
##########
@@ -376,6 +376,21 @@ private static void appendQueryOptions(StringBuilder buff, QueryOptions queryOpt
             buff.append("]");
             optionCount++;
         }
+        if (queryOptions.offset != -1) {
+            if (optionCount > 0) {
+                buff.append(", ");
+            }
+            buff.append("offset ");
+            buff.append(queryOptions.offset);
+            optionCount++;
+        }
+        if (queryOptions.limit != -1) {
+            if (optionCount > 0) {
+                buff.append(", ");
+            }
+            buff.append("limit ");
+            buff.append(queryOptions.limit);

Review Comment:
   Makes sense, I updated to add to a list and then join the list.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@jackrabbit.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org