You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@rocketmq.apache.org by GitBox <gi...@apache.org> on 2020/11/06 03:52:14 UTC
[GitHub] [rocketmq-client-go] vearne opened a new pull request #552: Feat/resolver
vearne opened a new pull request #552:
URL: https://github.com/apache/rocketmq-client-go/pull/552
## What is the purpose of the change
In my scenario, my nameservers are hosts represented by a group of domain names. So I need a new resolver to resolve the nameservers.
## Brief changelog
add dns Resolver to resolve name server
## Verifying this change
go test . -v --run TestDNSResolver
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq-client-go] xujianhai666 commented on pull request #552: Feat/resolver
Posted by GitBox <gi...@apache.org>.
xujianhai666 commented on pull request #552:
URL: https://github.com/apache/rocketmq-client-go/pull/552#issuecomment-734099572
fmt before pr agian. @vearne
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq-client-go] xujianhai666 merged pull request #552: Feat/resolver
Posted by GitBox <gi...@apache.org>.
xujianhai666 merged pull request #552:
URL: https://github.com/apache/rocketmq-client-go/pull/552
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq-client-go] vearne commented on pull request #552: Feat/resolver
Posted by GitBox <gi...@apache.org>.
vearne commented on pull request #552:
URL: https://github.com/apache/rocketmq-client-go/pull/552#issuecomment-738501025
@xujianhai666 Is something wrong in my comment?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq-client-go] vearne commented on pull request #552: Feat/resolver
Posted by GitBox <gi...@apache.org>.
vearne commented on pull request #552:
URL: https://github.com/apache/rocketmq-client-go/pull/552#issuecomment-737850776
> sorry for that I merge incorrectly, could pull request again with format "https://github.com/apache/rocketmq/wiki/RIP-14-RocketMQ-Community-Operation-Conventions"
Is something wrong in my comment?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq-client-go] vearne commented on pull request #552: Feat/resolver
Posted by GitBox <gi...@apache.org>.
vearne commented on pull request #552:
URL: https://github.com/apache/rocketmq-client-go/pull/552#issuecomment-734540101
ok
xujianhai666 <no...@github.com> 于2020年11月26日周四 下午2:21写道：
> fmt before pr agian. @vearne <https://github.com/vearne>
>
> —
> You are receiving this because you were mentioned.
> Reply to this email directly, view it on GitHub
> <https://github.com/apache/rocketmq-client-go/pull/552#issuecomment-734099572>,
> or unsubscribe
> <https://github.com/notifications/unsubscribe-auth/AB6GYNDWZ5FBOPX4OPLEXSTSRXXW7ANCNFSM4TMFX72A>
> .
>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq-client-go] codecov-io commented on pull request #552: Feat/resolver
Posted by GitBox <gi...@apache.org>.
codecov-io commented on pull request #552:
URL: https://github.com/apache/rocketmq-client-go/pull/552#issuecomment-734537702
# [Codecov](https://codecov.io/gh/apache/rocketmq-client-go/pull/552?src=pr&el=h1) Report
> Merging [#552](https://codecov.io/gh/apache/rocketmq-client-go/pull/552?src=pr&el=desc) (8208f59) into [master](https://codecov.io/gh/apache/rocketmq-client-go/commit/e1d9be806c182c142aee212eab27e413705f4e79?el=desc) (e1d9be8) will **increase** coverage by `0.12%`.
> The diff coverage is `60.00%`.
[](https://codecov.io/gh/apache/rocketmq-client-go/pull/552?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #552 +/- ##
==========================================
+ Coverage 24.21% 24.33% +0.12%
==========================================
Files 48 48
Lines 5010 5026 +16
==========================================
+ Hits 1213 1223 +10
- Misses 3598 3602 +4
- Partials 199 201 +2
```
| [Impacted Files](https://codecov.io/gh/apache/rocketmq-client-go/pull/552?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [primitive/nsresolver.go](https://codecov.io/gh/apache/rocketmq-client-go/pull/552/diff?src=pr&el=tree#diff-cHJpbWl0aXZlL25zcmVzb2x2ZXIuZ28=) | `55.14% <60.00%> (+0.79%)` | :arrow_up: |
| [consumer/push\_consumer.go](https://codecov.io/gh/apache/rocketmq-client-go/pull/552/diff?src=pr&el=tree#diff-Y29uc3VtZXIvcHVzaF9jb25zdW1lci5nbw==) | `11.46% <0.00%> (+0.12%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/rocketmq-client-go/pull/552?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/rocketmq-client-go/pull/552?src=pr&el=footer). Last update [e1d9be8...8208f59](https://codecov.io/gh/apache/rocketmq-client-go/pull/552?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq-client-go] xujianhai666 commented on pull request #552: Feat/resolver
Posted by GitBox <gi...@apache.org>.
xujianhai666 commented on pull request #552:
URL: https://github.com/apache/rocketmq-client-go/pull/552#issuecomment-737846870
sorry for that I merge incorrectly, could pull request again with format "https://github.com/apache/rocketmq/wiki/RIP-14-RocketMQ-Community-Operation-Conventions"
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq-client-go] codecov-io edited a comment on pull request #552: Feat/resolver
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #552:
URL: https://github.com/apache/rocketmq-client-go/pull/552#issuecomment-734537702
# [Codecov](https://codecov.io/gh/apache/rocketmq-client-go/pull/552?src=pr&el=h1) Report
> Merging [#552](https://codecov.io/gh/apache/rocketmq-client-go/pull/552?src=pr&el=desc) (8208f59) into [master](https://codecov.io/gh/apache/rocketmq-client-go/commit/e1d9be806c182c142aee212eab27e413705f4e79?el=desc) (e1d9be8) will **increase** coverage by `0.12%`.
> The diff coverage is `60.00%`.
[](https://codecov.io/gh/apache/rocketmq-client-go/pull/552?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #552 +/- ##
==========================================
+ Coverage 24.21% 24.33% +0.12%
==========================================
Files 48 48
Lines 5010 5026 +16
==========================================
+ Hits 1213 1223 +10
- Misses 3598 3602 +4
- Partials 199 201 +2
```
| [Impacted Files](https://codecov.io/gh/apache/rocketmq-client-go/pull/552?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [primitive/nsresolver.go](https://codecov.io/gh/apache/rocketmq-client-go/pull/552/diff?src=pr&el=tree#diff-cHJpbWl0aXZlL25zcmVzb2x2ZXIuZ28=) | `55.14% <60.00%> (+0.79%)` | :arrow_up: |
| [consumer/push\_consumer.go](https://codecov.io/gh/apache/rocketmq-client-go/pull/552/diff?src=pr&el=tree#diff-Y29uc3VtZXIvcHVzaF9jb25zdW1lci5nbw==) | `11.46% <0.00%> (+0.12%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/rocketmq-client-go/pull/552?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/rocketmq-client-go/pull/552?src=pr&el=footer). Last update [e1d9be8...8208f59](https://codecov.io/gh/apache/rocketmq-client-go/pull/552?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org