You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@jclouds.apache.org by Zack Shoylev <no...@github.com> on 2014/11/14 14:33:38 UTC

[jclouds-labs-openstack] Use the right variable for osgi in the pom. (#170)

You can merge this Pull Request by running:

  git pull https://github.com/rackerlabs/jclouds-labs-openstack neutron-osgi-fix

Or you can view, comment on it, or merge it online at:

  https://github.com/jclouds/jclouds-labs-openstack/pull/170

-- Commit Summary --

  * Use the right variable for osgi in the pom.

-- File Changes --

    M openstack-neutron/pom.xml (9)

-- Patch Links --

https://github.com/jclouds/jclouds-labs-openstack/pull/170.patch
https://github.com/jclouds/jclouds-labs-openstack/pull/170.diff

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs-openstack/pull/170

Re: [jclouds-labs-openstack] Use the right variable for osgi in the pom. (#170)

Posted by Andrew Phillips <no...@github.com>.

PS: Looks like some other POMs are affected here, too:
```
C:\Users\aphillips\Workspaces\Personal\jclouds\jclouds-labs-openstack>findstr /C
:"jclouds.version" /S pom.xml
openstack-glance\pom.xml:      org.jclouds.rest.internal;version="${jclouds.version}",
openstack-glance\pom.xml:      org.jclouds*;version="${jclouds.version}",
openstack-neutron\pom.xml:      org.jclouds.rest.internal;version="${jclouds.version}",
openstack-neutron\pom.xml:      org.jclouds*;version="${jclouds.version}",
rackspace-autoscale\pom.xml:      org.jclouds.rest.internal;version="${jclouds.version}",
rackspace-autoscale\pom.xml:      org.jclouds*;version="${jclouds.version}",
rackspace-autoscale-uk\pom.xml:      org.jclouds.rest.internal;version="${jclouds.version}",
rackspace-autoscale-uk\pom.xml:      org.jclouds*;version="${jclouds.version}",
rackspace-autoscale-us\pom.xml:      org.jclouds.rest.internal;version="${jclouds.version}",
rackspace-autoscale-us\pom.xml:      org.jclouds*;version="${jclouds.version}",
rackspace-cloudbigdata\pom.xml:      org.jclouds.rest.internal;version="${jclouds.version}",
rackspace-cloudbigdata\pom.xml:      org.jclouds*;version="${jclouds.version}",
rackspace-cloudbigdata-us\pom.xml:      org.jclouds.rest.internal;version="${jclouds.version}",
rackspace-cloudbigdata-us\pom.xml:      org.jclouds*;version="${jclouds.version}
",
rackspace-cloudfiles\pom.xml:    <jclouds.osgi.import>org.jclouds*;version="${jclouds.version}",*</jclouds.osgi.import>
rackspace-cloudfiles-uk\pom.xml:      org.jclouds.rest.internal;version="${jclouds.version}",
rackspace-cloudfiles-uk\pom.xml:      org.jclouds*;version="${jclouds.version}",
rackspace-cloudfiles-us\pom.xml:      org.jclouds.rest.internal;version="${jclouds.version}",
rackspace-cloudfiles-us\pom.xml:      org.jclouds*;version="${jclouds.version}",
```

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs-openstack/pull/170#issuecomment-63086276

Re: [jclouds-labs-openstack] Use the right variable for osgi in the pom. (#170)

Posted by BuildHive <no...@github.com>.

[jclouds » jclouds-labs-openstack #1967](https://buildhive.cloudbees.com/job/jclouds/job/jclouds-labs-openstack/1967/) SUCCESS
This pull request looks good
[(what's this?)](https://www.cloudbees.com/what-is-buildhive)

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs-openstack/pull/170#issuecomment-63107484

Re: [jclouds-labs-openstack] Use the right variable for osgi in the pom. (#170)

Posted by Zack Shoylev <no...@github.com>.

backported to 1.8.x

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs-openstack/pull/170#issuecomment-63169715

Re: [jclouds-labs-openstack] Use the right variable for osgi in the pom. (#170)

Posted by CloudBees pull request builder plugin <no...@github.com>.

[jclouds-labs-openstack-pull-requests #489](https://jclouds.ci.cloudbees.com/job/jclouds-labs-openstack-pull-requests/489/) SUCCESS
This pull request looks good

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs-openstack/pull/170#issuecomment-63106296

Re: [jclouds-labs-openstack] Use the right variable for osgi in the pom. (#170)

Posted by CloudBees pull request builder plugin <no...@github.com>.

[jclouds-labs-openstack-pull-requests #487](https://jclouds.ci.cloudbees.com/job/jclouds-labs-openstack-pull-requests/487/) SUCCESS
This pull request looks good

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs-openstack/pull/170#issuecomment-63065073

Re: [jclouds-labs-openstack] Use the right variable for osgi in the pom. (#170)

Posted by Zack Shoylev <no...@github.com>.

squashed and merged

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs-openstack/pull/170#issuecomment-63106782

Re: [jclouds-labs-openstack] Use the right variable for osgi in the pom. (#170)

Posted by Andrew Phillips <no...@github.com>.

@zack-shoylev Code changes themselves look good. I notice that in Neutron we're removing the `org.jclouds.rest.internal` and `org.jclouds.labs` imports...is that something we could be doing for the other providers too?

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs-openstack/pull/170#issuecomment-63202903

Re: [jclouds-labs-openstack] Use the right variable for osgi in the pom. (#170)

Posted by Zack Shoylev <no...@github.com>.

I am not completely sure - but it's a good idea to check.
________________________________
From: Andrew Phillips [notifications@github.com]
Sent: Saturday, November 15, 2014 9:41 PM
To: jclouds/jclouds-labs-openstack
Cc: Zack Shoylev
Subject: Re: [jclouds-labs-openstack] Use the right variable for osgi in the pom. (#170)

@zack-shoylev<https://github.com/zack-shoylev> Code changes themselves look good. I notice that in Neutron we're removing the org.jclouds.rest.internal and org.jclouds.labs imports...is that something we could be doing for the other providers too?

—
Reply to this email directly or view it on GitHub<https://github.com/jclouds/jclouds-labs-openstack/pull/170#issuecomment-63202903>.

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs-openstack/pull/170#issuecomment-63236414

Re: [jclouds-labs-openstack] Use the right variable for osgi in the pom. (#170)

Posted by Zack Shoylev <no...@github.com>.

Closed #170.

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs-openstack/pull/170#event-193507255

Re: [jclouds-labs-openstack] Use the right variable for osgi in the pom. (#170)

Posted by Zack Shoylev <no...@github.com>.

I have expanded the PR. Still looking good?

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs-openstack/pull/170#issuecomment-63088585

Re: [jclouds-labs-openstack] Use the right variable for osgi in the pom. (#170)

Posted by BuildHive <no...@github.com>.

[jclouds » jclouds-labs-openstack #1966](https://buildhive.cloudbees.com/job/jclouds/job/jclouds-labs-openstack/1966/) SUCCESS
This pull request looks good
[(what's this?)](https://www.cloudbees.com/what-is-buildhive)

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs-openstack/pull/170#issuecomment-63090297

Re: [jclouds-labs-openstack] Use the right variable for osgi in the pom. (#170)

Posted by BuildHive <no...@github.com>.

[jclouds » jclouds-labs-openstack #1965](https://buildhive.cloudbees.com/job/jclouds/job/jclouds-labs-openstack/1965/) SUCCESS
This pull request looks good
[(what's this?)](https://www.cloudbees.com/what-is-buildhive)

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs-openstack/pull/170#issuecomment-63065922

Re: [jclouds-labs-openstack] Use the right variable for osgi in the pom. (#170)

Posted by CloudBees pull request builder plugin <no...@github.com>.

[jclouds-labs-openstack-pull-requests #488](https://jclouds.ci.cloudbees.com/job/jclouds-labs-openstack-pull-requests/488/) SUCCESS
This pull request looks good

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs-openstack/pull/170#issuecomment-63089186

Re: [jclouds-labs-openstack] Use the right variable for osgi in the pom. (#170)

Posted by Andrew Phillips <no...@github.com>.

+1 - looks good to me. Should check if this change works with Karaf downstream, but we can do that after a merge.

Thanks, @zack-shoylev!

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs-openstack/pull/170#issuecomment-63073388