You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@myfaces.apache.org by GitBox <gi...@apache.org> on 2022/11/14 19:55:25 UTC

[GitHub] [myfaces] volosied commented on a diff in pull request #381: Add xml preamble to every ajax response

volosied commented on code in PR #381:
URL: https://github.com/apache/myfaces/pull/381#discussion_r1021997052


##########
api/src/main/java/jakarta/faces/context/PartialResponseWriter.java:
##########
@@ -130,6 +130,8 @@ public void startDocument() throws IOException
         // use writePreamble(...)
         //_wrapped.write("<?xml version=\"1.0\" encoding=\"utf-8\"?>");

Review Comment:
   Maybe I should also use writePreamble()? 
   
   I'll update the PR. 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@myfaces.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org