You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@impala.apache.org by jo...@apache.org on 2025/03/31 23:52:08 UTC

(impala) branch master updated: IMPALA-13900: Exempt enable_tuple_cache_verification from tuple cache key

This is an automated email from the ASF dual-hosted git repository.

joemcdonnell pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/impala.git


The following commit(s) were added to refs/heads/master by this push:
     new 033a86d4b IMPALA-13900: Exempt enable_tuple_cache_verification from tuple cache key
033a86d4b is described below

commit 033a86d4b369fd3252a30083d6424f2dc3706621
Author: Joe McDonnell <jo...@cloudera.com>
AuthorDate: Tue Mar 25 12:41:09 2025 -0700

    IMPALA-13900: Exempt enable_tuple_cache_verification from tuple cache key
    
    The tuple cache key includes all query options that are not
    explicitly excluded. This currently includes enable_tuple_cache_verification.
    It is useful to be able to run queries back to back with
    enable_tuple_cache_verification=true vs false with the same
    cache entry. This exempts enable_tuple_cache_verification from the
    tuple cache key.
    
    Testing:
     - Hand testing
    
    Change-Id: I18a1740d6151870186548161493f6adbe0f4aa96
    Reviewed-on: http://gerrit.cloudera.org:8080/22664
    Reviewed-by: Yida Wu <wy...@gmail.com>
    Tested-by: Impala Public Jenkins <im...@cloudera.com>
---
 be/src/service/query-options.h | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/be/src/service/query-options.h b/be/src/service/query-options.h
index 6b4973a30..3a50a3862 100644
--- a/be/src/service/query-options.h
+++ b/be/src/service/query-options.h
@@ -358,8 +358,8 @@ constexpr unsigned NUM_QUERY_OPTIONS =
       TQueryOptionLevel::ADVANCED)                                                       \
   TUPLE_CACHE_EXEMPT_QUERY_OPT_FN(long_polling_time_ms, LONG_POLLING_TIME_MS,            \
       TQueryOptionLevel::REGULAR)                                                        \
-  QUERY_OPT_FN(enable_tuple_cache_verification, ENABLE_TUPLE_CACHE_VERIFICATION,         \
-      TQueryOptionLevel::ADVANCED)                                                       \
+  TUPLE_CACHE_EXEMPT_QUERY_OPT_FN(enable_tuple_cache_verification,                       \
+      ENABLE_TUPLE_CACHE_VERIFICATION, TQueryOptionLevel::ADVANCED)                      \
   QUERY_OPT_FN(enable_tuple_analysis_in_aggregate,                                       \
       ENABLE_TUPLE_ANALYSIS_IN_AGGREGATE, TQueryOptionLevel::ADVANCED)                   \
   QUERY_OPT_FN(estimate_duplicate_in_preagg,                                             \