You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@parquet.apache.org by "Fokko (via GitHub)" <gi...@apache.org> on 2023/11/28 23:11:01 UTC

[PR] PARQUET-2392: Remove StringBuilder in `LogicalTypeAnnotation` [parquet-mr]

Fokko opened a new pull request, #1215:
URL: https://github.com/apache/parquet-mr/pull/1215

   Make sure you have checked _all_ steps below.
   
   StringBuilder only makes sense when you concatenate in a loop.
   
   ### Jira
   
   - [ ] My PR addresses the following [Parquet Jira](https://issues.apache.org/jira/browse/PARQUET/) issues and references them in the PR title. For example, "PARQUET-1234: My Parquet PR"
     - https://issues.apache.org/jira/browse/PARQUET-2392
     - In case you are adding a dependency, check if the license complies with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
   
   ### Tests
   
   - [ ] My PR adds the following unit tests __OR__ does not need testing for this extremely good reason:
   
   ### Commits
   
   - [ ] My commits all reference Jira issues in their subject lines. In addition, my commits follow the guidelines from "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)":
     1. Subject is separated from body by a blank line
     1. Subject is limited to 50 characters (not including Jira issue reference)
     1. Subject does not end with a period
     1. Subject uses the imperative mood ("add", not "adding")
     1. Body wraps at 72 characters
     1. Body explains "what" and "why", not "how"
   
   ### Documentation
   
   - [ ] In case of new functionality, my PR adds documentation that describes how to use it.
     - All the public functions and the classes in the PR contain Javadoc that explain what it does
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@parquet.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] PARQUET-2392: Remove StringBuilder in `LogicalTypeAnnotation` [parquet-mr]

Posted by "Fokko (via GitHub)" <gi...@apache.org>.
Fokko commented on PR #1215:
URL: https://github.com/apache/parquet-mr/pull/1215#issuecomment-1833844311

   @zhangjiashen Thanks for the review, appreciate it! I don't think there are any negative performance implications since the compile will just optimize it to a single concatenation. `StringBuilders` should only be used when you concatenate in a loop (fields in a schema for example).


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@parquet.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] PARQUET-2392: Remove StringBuilder in `LogicalTypeAnnotation` [parquet-mr]

Posted by "Fokko (via GitHub)" <gi...@apache.org>.
Fokko merged PR #1215:
URL: https://github.com/apache/parquet-mr/pull/1215


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@parquet.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org