You are viewing a plain text version of this content. The canonical link for it is here.

Posted to jira@kafka.apache.org by "wperlichek (via GitHub)" <gi...@apache.org> on 2024/11/03 21:55:50 UTC

[PR] (MINOR) testElectPreferredLeaders, reduced leader lookups [kafka]

wperlichek opened a new pull request, #17677:
URL: https://github.com/apache/kafka/pull/17677

   This change is aimed at improving test logging and aiding in debugging.
   
   I noticed that `testElectPreferredLeaders()` has been flaky or has failed recently, [Develocity](https://ge.apache.org/scans/tests?search.names=CI%20workflow,Git%20repository&search.relativeStartTime=P90D&search.rootProjectNames=kafka&search.tags=github,trunk&search.tasks=test&search.timeZoneId=America%2FLos_Angeles&search.values=CI,https:%2F%2Fgithub.com%2Fapache%2Fkafka&tests.container=kafka.api.PlaintextAdminIntegrationTest&tests.test=testElectPreferredLeaders(String)%5B1%5D). 
   
   Previously, the test made calls to the `preferredLeader()` method within both the lambda and the error message in the `TestUtils.waitUntilTrue` block. These repeated calls could potentially be misleading (or even inaccurate) when diagnosing test failures, as they might reflect different leader states.
   
   This update simplifies the test by storing the result of `preferredLeader()` in temporary variables, which are then consistently used in both the lambda and error message. This should make the test output clearer and more reliable for debugging.
   
   ### Committer Checklist (excluded from commit message)
   - [ ] Verify design and implementation 
   - [ ] Verify test coverage and CI build status
   - [ ] Verify documentation (including upgrade notes)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] MINOR: Improve Debugging and Logging in testElectPreferredLeaders [kafka]

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.

github-actions[bot] commented on PR #17677:
URL: https://github.com/apache/kafka/pull/17677#issuecomment-2635630086

   This PR is being marked as stale since it has not had any activity in 90 days. If you
   would like to keep this PR alive, please leave a comment asking for a review. If the PR has 
   merge conflicts, update it with the latest from the base branch.
   <p>
   If you are having difficulty finding a reviewer, please reach out on the 
   [mailing list](https://kafka.apache.org/contact).
   <p>
   If this PR is no longer valid or desired, please feel free to close it. If no activity
   occurs in the next 30 days, it will be automatically closed.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] MINOR: Improve Debugging and Logging in testElectPreferredLeaders [kafka]

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.

github-actions[bot] commented on PR #17677:
URL: https://github.com/apache/kafka/pull/17677#issuecomment-2705455616

   This PR has been closed since it has not had any activity in 120 days. If you feel like this
   was a mistake, or you would like to continue working on it, please feel free to re-open the 
   PR and ask for a review.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] MINOR: Improve Debugging and Logging in testElectPreferredLeaders [kafka]

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.

github-actions[bot] closed pull request #17677: MINOR: Improve Debugging and Logging in testElectPreferredLeaders
URL: https://github.com/apache/kafka/pull/17677


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org