You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jira@kafka.apache.org by GitBox <gi...@apache.org> on 2020/06/02 14:12:55 UTC

[GitHub] [kafka] nizhikov opened a new pull request #8779: [MINOR] Fixing spotbug fail - removing unused variable.

nizhikov opened a new pull request #8779:
URL: https://github.com/apache/kafka/pull/8779


   Fixing nit in c6633a157eec1712116d294eb3785a96cba4e331.
   This commit break spotbug check with the "Dead store to isFreshAssignment in org.apache.kafka.clients.consumer.internals.AbstractStickyAssignor.generalAssign(Map, Map)"
   
   ### Committer Checklist (excluded from commit message)
   - [ ] Verify design and implementation 
   - [ ] Verify test coverage and CI build status
   - [ ] Verify documentation (including upgrade notes)
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [kafka] nizhikov commented on pull request #8779: [MINOR] Fixing spotbug fail - removing unused variable.

Posted by GitBox <gi...@apache.org>.
nizhikov commented on pull request #8779:
URL: https://github.com/apache/kafka/pull/8779#issuecomment-637570728


   Hello @ableegoldman 
   It looks like your patch breaks spot bug check.
   I prepared oneliner fix for it.
   
   Can you, please, take a look?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [kafka] guozhangwang commented on pull request #8779: [MINOR] Fixing spotbug fail - removing unused variable.

Posted by GitBox <gi...@apache.org>.
guozhangwang commented on pull request #8779:
URL: https://github.com/apache/kafka/pull/8779#issuecomment-637676075


   Cherry-picked to 2.6 / 2.5 / 2.4


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [kafka] ijuma merged pull request #8779: [MINOR] Fixing spotbug fail - removing unused variable.

Posted by GitBox <gi...@apache.org>.
ijuma merged pull request #8779:
URL: https://github.com/apache/kafka/pull/8779


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org