[GitHub] spark pull request #19773: [SPARK-22546][SQL] Supporting for changing column...

[maropu <gi...@git.apache.org>]

Github user maropu commented on a diff in the pull request:

    https://github.com/apache/spark/pull/19773#discussion_r215279164
  
    --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/command/ddl.scala ---
    @@ -318,18 +318,34 @@ case class AlterTableChangeColumnCommand(
     
         // Find the origin column from dataSchema by column name.
         val originColumn = findColumnByName(table.dataSchema, columnName, resolver)
    -    // Throw an AnalysisException if the column name/dataType is changed.
    +    // Throw an AnalysisException if the column name is changed.
         if (!columnEqual(originColumn, newColumn, resolver)) {
    --- End diff --
    
    Its ok to check names only?


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org