You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by "potiuk (via GitHub)" <gi...@apache.org> on 2023/02/06 09:57:58 UTC
[GitHub] [airflow] potiuk opened a new pull request, #29381: Remove stderr redirection for get-workflow-info
potiuk opened a new pull request, #29381:
URL: https://github.com/apache/airflow/pull/29381
The #28514 change added capability of getting trace errors for the command by swapping redirection of stderr and stdout, but debug output for github_output file remoined in stderr.
This was no problem in most cases as rich did not produce color codes for stderr redirection and github_output was able to parse it properly - and each line in the GITHHUB_OUTPUT was simply duplicated.
However, when number of labels was big, rich split the message and it caused Invalid format message.
<!--
Thank you for contributing! Please make sure that your code changes
are covered with tests. And in case of new features or big changes
remember to adjust the documentation.
Feel free to ping committers for the review!
In case of an existing issue, reference it using one of the following:
closes: #ISSUE
related: #ISSUE
How to write a good git commit message:
http://chris.beams.io/posts/git-commit/
-->
---
**^ Add meaningful description above**
Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst#pull-request-guidelines)** for more information.
In case of fundamental code changes, an Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvement+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in a newsfragment file, named `{pr_number}.significant.rst` or `{issue_number}.significant.rst`, in [newsfragments](https://github.com/apache/airflow/tree/main/newsfragments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #29381: Remove stderr redirection for get-workflow-info
Posted by "potiuk (via GitHub)" <gi...@apache.org>.
potiuk commented on PR #29381:
URL: https://github.com/apache/airflow/pull/29381#issuecomment-1419218296
We can merge that one now. Looking at the `git version` issue now in #29386. It is certainly not related and at least we will find out if this one work with other PRs as well.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #29381: Remove stderr redirection for get-workflow-info
Posted by "potiuk (via GitHub)" <gi...@apache.org>.
potiuk commented on PR #29381:
URL: https://github.com/apache/airflow/pull/29381#issuecomment-1418909904
There is a different error - but the error is due to something that started to happen over the weekend wiith addding github remote. I am trying to see what it is in https://github.com/apache/airflow/pull/29385
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk merged pull request #29381: Remove stderr redirection for get-workflow-info
Posted by "potiuk (via GitHub)" <gi...@apache.org>.
potiuk merged PR #29381:
URL: https://github.com/apache/airflow/pull/29381
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org