You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2022/12/16 14:55:58 UTC

[GitHub] [airflow] MrGeorgeOwl opened a new pull request, #28406: Add defer mode to GKECreateClusterOperator and GKEDeleteClusterOperator

MrGeorgeOwl opened a new pull request, #28406:
URL: https://github.com/apache/airflow/pull/28406

   <!--
   Thank you for contributing! Please make sure that your code changes
   are covered with tests. And in case of new features or big changes
   remember to adjust the documentation.
   
   Feel free to ping committers for the review!
   
   In case of an existing issue, reference it using one of the following:
   
   closes: #ISSUE
   related: #ISSUE
   
   How to write a good git commit message:
   http://chris.beams.io/posts/git-commit/
   -->
   
   ---
   **^ Add meaningful description above**
   
   Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst#pull-request-guidelines)** for more information.
   In case of fundamental code changes, an Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvement+Proposals)) is needed.
   In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
   In case of backwards incompatible changes please leave a note in a newsfragment file, named `{pr_number}.significant.rst` or `{issue_number}.significant.rst`, in [newsfragments](https://github.com/apache/airflow/tree/main/newsfragments).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [airflow] potiuk commented on pull request #28406: Add defer mode to GKECreateClusterOperator and GKEDeleteClusterOperator

Posted by "potiuk (via GitHub)" <gi...@apache.org>.
potiuk commented on PR #28406:
URL: https://github.com/apache/airflow/pull/28406#issuecomment-1400853873

   Just checking with @kaxil and @bhirsz - weren't you working on this already in Astronomer/Google ?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [airflow] kaxil merged pull request #28406: Add defer mode to GKECreateClusterOperator and GKEDeleteClusterOperator

Posted by "kaxil (via GitHub)" <gi...@apache.org>.
kaxil merged PR #28406:
URL: https://github.com/apache/airflow/pull/28406


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [airflow] MrGeorgeOwl commented on pull request #28406: Add defer mode to GKECreateClusterOperator and GKEDeleteClusterOperator

Posted by "MrGeorgeOwl (via GitHub)" <gi...@apache.org>.
MrGeorgeOwl commented on PR #28406:
URL: https://github.com/apache/airflow/pull/28406#issuecomment-1401512853

   @potiuk Yes, I am also working on KubernetesPodOperator but this PR have different operators


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [airflow] potiuk commented on pull request #28406: Add defer mode to GKECreateClusterOperator and GKEDeleteClusterOperator

Posted by GitBox <gi...@apache.org>.
potiuk commented on PR #28406:
URL: https://github.com/apache/airflow/pull/28406#issuecomment-1379612860

   conflicts.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [airflow] MrGeorgeOwl commented on pull request #28406: Add defer mode to GKECreateClusterOperator and GKEDeleteClusterOperator

Posted by "MrGeorgeOwl (via GitHub)" <gi...@apache.org>.
MrGeorgeOwl commented on PR #28406:
URL: https://github.com/apache/airflow/pull/28406#issuecomment-1400598190

   @potiuk, I think PR is good and can be merged


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [airflow] VladaZakharova commented on pull request #28406: Add defer mode to GKECreateClusterOperator and GKEDeleteClusterOperator

Posted by "VladaZakharova (via GitHub)" <gi...@apache.org>.
VladaZakharova commented on PR #28406:
URL: https://github.com/apache/airflow/pull/28406#issuecomment-1420963908

   Hi Team! @kaxil @potiuk 
   Can we please merge these changes? 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org