You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@yunikorn.apache.org by GitBox <gi...@apache.org> on 2021/09/23 15:35:26 UTC

[GitHub] [incubator-yunikorn-core] craigcondit commented on pull request #325: [YUNIKORN-859] Add "resource weighting" to /ws/v1/partitions

craigcondit commented on pull request #325:
URL: https://github.com/apache/incubator-yunikorn-core/pull/325#issuecomment-925926808


   @chia7712, thanks for the patch!
   
   Looks good to me, though I think we will have a slight backwards incompatibility in the REST API since `NodeSortingPolicy` changes from a string to an object.
   
   @yangwwei, @wilfred-s, can either of you take a look as well?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@yunikorn.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org