You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@impala.apache.org by "Casey Ching (Code Review)" <ge...@cloudera.org> on 2016/06/07 07:00:23 UTC
[Impala-CR](cdh5-trunk) IMPALA-3650: DISTRIBUTE BY required for managed Kudu tables
Casey Ching has uploaded a new change for review.
http://gerrit.cloudera.org:8080/3325
Change subject: IMPALA-3650: DISTRIBUTE BY required for managed Kudu tables
......................................................................
IMPALA-3650: DISTRIBUTE BY required for managed Kudu tables
As of Kudu 0.9, DISTRIBUTE BY is now required when creating a new Kudu
table. Create table analysis and test are updated to reflect this.
Note: this requires upgrading Kudu to 0.9 (not yet in the toolchain).
Change-Id: Icf2660d0c81a30da706c2df568c1cf272203054f
---
M bin/impala-config.sh
M fe/src/main/java/com/cloudera/impala/analysis/CreateTableStmt.java
M fe/src/test/java/com/cloudera/impala/analysis/AnalyzeDDLTest.java
M testdata/workloads/functional-query/queries/QueryTest/create_kudu.test
M testdata/workloads/functional-query/queries/QueryTest/kudu-scan-node.test
M testdata/workloads/functional-query/queries/QueryTest/kudu-show-create.test
M testdata/workloads/functional-query/queries/QueryTest/kudu_alter.test
M testdata/workloads/functional-query/queries/QueryTest/kudu_crud.test
M tests/query_test/test_kudu.py
9 files changed, 53 insertions(+), 14 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala refs/changes/25/3325/1
--
To view, visit http://gerrit.cloudera.org:8080/3325
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Icf2660d0c81a30da706c2df568c1cf272203054f
Gerrit-PatchSet: 1
Gerrit-Project: Impala
Gerrit-Branch: cdh5-trunk
Gerrit-Owner: Casey Ching <ca...@cloudera.com>
[Impala-CR](cdh5-trunk) IMPALA-3650: DISTRIBUTE BY required for managed Kudu tables
Posted by "Matthew Jacobs (Code Review)" <ge...@cloudera.org>.
Matthew Jacobs has posted comments on this change.
Change subject: IMPALA-3650: DISTRIBUTE BY required for managed Kudu tables
......................................................................
Patch Set 1:
> (2 comments)
>
> I think generate-schema-statements.py may need to be updated. The
> data loading code allows you to create a kudu table implicitly
> (build_table_template() gets called), and in that case you wouldn't
> have a DISTRIBUTE BY clause. E.g. it looks like functional_kudu.testtbl
> will break.
We may want to have a CREATE_KUDU section for testtbl as we do for the others and then disallow the kudu path in build_table_template() for now. It generates this sql:
CREATE DATABASE IF NOT EXISTS functional_kudu;
CREATE TABLE IF NOT EXISTS functional_kudu.testtbl (
id bigint,
name string,
zip int)
TBLPROPERTIES (
'kudu.table_name' = 'testtbl',
'storage_handler' = 'com.cloudera.kudu.hive.KuduStorageHandler',
'kudu.master_addresses' = '127.0.0.1:7051',
'kudu.key_columns' = 'id'
);
--
To view, visit http://gerrit.cloudera.org:8080/3325
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Icf2660d0c81a30da706c2df568c1cf272203054f
Gerrit-PatchSet: 1
Gerrit-Project: Impala
Gerrit-Branch: cdh5-trunk
Gerrit-Owner: Casey Ching <ca...@cloudera.com>
Gerrit-Reviewer: Matthew Jacobs <mj...@cloudera.com>
Gerrit-HasComments: No
[Impala-CR](cdh5-trunk) IMPALA-3650: DISTRIBUTE BY required for managed Kudu tables
Posted by "Matthew Jacobs (Code Review)" <ge...@cloudera.org>.
Matthew Jacobs has posted comments on this change.
Change subject: IMPALA-3650: DISTRIBUTE BY required for managed Kudu tables
......................................................................
Patch Set 1:
(2 comments)
I think generate-schema-statements.py may need to be updated. The data loading code allows you to create a kudu table implicitly (build_table_template() gets called), and in that case you wouldn't have a DISTRIBUTE BY clause. E.g. it looks like functional_kudu.testtbl will break.
http://gerrit.cloudera.org:8080/#/c/3325/1/bin/impala-config.sh
File bin/impala-config.sh:
PS1, Line 240: 0.9.0-RC1
can we bump this to 0.9.0 now that it's released?
PS1, Line 275: SNAPSHOT
Can we update this to 0.9.0 now that it's been released? Is the TODO above still relevant?
--
To view, visit http://gerrit.cloudera.org:8080/3325
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Icf2660d0c81a30da706c2df568c1cf272203054f
Gerrit-PatchSet: 1
Gerrit-Project: Impala
Gerrit-Branch: cdh5-trunk
Gerrit-Owner: Casey Ching <ca...@cloudera.com>
Gerrit-Reviewer: Matthew Jacobs <mj...@cloudera.com>
Gerrit-HasComments: Yes
[Impala-CR](cdh5-trunk) IMPALA-3650: DISTRIBUTE BY required for managed Kudu tables
Posted by "Jim Apple (Code Review)" <ge...@cloudera.org>.
Jim Apple has posted comments on this change.
Change subject: IMPALA-3650: DISTRIBUTE BY required for managed Kudu tables
......................................................................
Patch Set 1:
Please update to using the new gerrit project, "Impala-ASF".
Instructions are here:
https://cwiki.apache.org/confluence/display/IMPALA/How+to+switch+to+Apache-hosted+git
Pushes to this project will be disabled on October 1.
--
To view, visit http://gerrit.cloudera.org:8080/3325
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Icf2660d0c81a30da706c2df568c1cf272203054f
Gerrit-PatchSet: 1
Gerrit-Project: Impala
Gerrit-Branch: cdh5-trunk
Gerrit-Owner: Casey Ching <ca...@cloudera.com>
Gerrit-Reviewer: Jim Apple <jb...@cloudera.com>
Gerrit-Reviewer: Matthew Jacobs <mj...@cloudera.com>
Gerrit-HasComments: No
[Impala-CR](cdh5-trunk) IMPALA-3650: DISTRIBUTE BY required for managed Kudu tables
Posted by "Matthew Jacobs (Code Review)" <ge...@cloudera.org>.
Matthew Jacobs has abandoned this change.
Change subject: IMPALA-3650: DISTRIBUTE BY required for managed Kudu tables
......................................................................
Abandoned
--
To view, visit http://gerrit.cloudera.org:8080/3325
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: abandon
Gerrit-Change-Id: Icf2660d0c81a30da706c2df568c1cf272203054f
Gerrit-PatchSet: 1
Gerrit-Project: Impala
Gerrit-Branch: cdh5-trunk
Gerrit-Owner: Casey Ching <ca...@cloudera.com>
Gerrit-Reviewer: Jim Apple <jb...@cloudera.com>
Gerrit-Reviewer: Matthew Jacobs <mj...@cloudera.com>