You are viewing a plain text version of this content. The canonical link for it is here.

Posted to jira@arrow.apache.org by "Vibhatha Lakmal Abeykoon (Jira)" <ji...@apache.org> on 2022/06/24 08:04:00 UTC

[jira] [Commented] (ARROW-16896) [C++] Adding ToProto for ExtensionSet

    [ https://issues.apache.org/jira/browse/ARROW-16896?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17558375#comment-17558375 ] 

Vibhatha Lakmal Abeykoon commented on ARROW-16896:
--------------------------------------------------

I think once this feature is implemented, we can replace what is in the `Status AddExtensionSetToPlan(const ExtensionSet& ext_set, substrait::Plan* plan)`[1] function by the set of functions written in this PR. 

[1][https://github.com/apache/arrow/blob/86915807af6fe10f44bc881e57b2f425f97c56c7/cpp/src/arrow/engine/substrait/plan_internal.cc#L38] 

cc [~westonpace] 

> [C++] Adding ToProto for ExtensionSet
> -------------------------------------
>
>                 Key: ARROW-16896
>                 URL: https://issues.apache.org/jira/browse/ARROW-16896
>             Project: Apache Arrow
>          Issue Type: Improvement
>            Reporter: Vibhatha Lakmal Abeykoon
>            Assignee: Vibhatha Lakmal Abeykoon
>            Priority: Major
>
> `ExtensionSet` needs to be converted ACERO->Substrait. 
> `{{{}substrait::extension::SimpleExtensionURI{}}}`, `{{{}substrait::extensions::SimpleExtensionDeclaration`{}}} and `{{{}substrait::extensions::AdvancedExtension`{}}} needs to be created by using an existing `ExtensionSet` object. 



--
This message was sent by Atlassian Jira
(v8.20.7#820007)