You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Timothy Chen <tn...@apache.org> on 2015/12/26 21:28:52 UTC
Review Request 41728: Removed docker provisioner port slave flags.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41728/
-----------------------------------------------------------
Review request for mesos, Gilbert Song, Jie Yu, and Jojy Varghese.
Repository: mesos
Description
-------
Removed docker provisioner port slave flags.
Diffs
-----
src/slave/containerizer/mesos/provisioner/docker/registry_client.hpp 798431c737691405a15989b1eb9ed5319ea0dacd
src/slave/containerizer/mesos/provisioner/docker/registry_puller.cpp 7cdb15b9529eab82867b3470a016bb8ad09ff250
src/slave/flags.hpp 1250786d1bdc8b312a1912a37ac8aac373dd5ec9
src/slave/flags.cpp c4343ab7ff7b7b4d2c335119d41319b0779d2806
src/tests/containerizer/provisioner_docker_tests.cpp bb142f5ea99e8ea9b20a896f95ae37aa1d8d3f98
Diff: https://reviews.apache.org/r/41728/diff/
Testing
-------
make check
Thanks,
Timothy Chen
Re: Review Request 41728: Removed docker provisioner port slave flags.
Posted by Jojy Varghese <jo...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41728/#review111917
-----------------------------------------------------------
Ship it!
Ship It!
- Jojy Varghese
On Dec. 26, 2015, 8:28 p.m., Timothy Chen wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41728/
> -----------------------------------------------------------
>
> (Updated Dec. 26, 2015, 8:28 p.m.)
>
>
> Review request for mesos, Gilbert Song, Jie Yu, and Jojy Varghese.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Removed docker provisioner port slave flags.
>
>
> Diffs
> -----
>
> src/slave/containerizer/mesos/provisioner/docker/registry_client.hpp 798431c737691405a15989b1eb9ed5319ea0dacd
> src/slave/containerizer/mesos/provisioner/docker/registry_puller.cpp 7cdb15b9529eab82867b3470a016bb8ad09ff250
> src/slave/flags.hpp 1250786d1bdc8b312a1912a37ac8aac373dd5ec9
> src/slave/flags.cpp c4343ab7ff7b7b4d2c335119d41319b0779d2806
> src/tests/containerizer/provisioner_docker_tests.cpp bb142f5ea99e8ea9b20a896f95ae37aa1d8d3f98
>
> Diff: https://reviews.apache.org/r/41728/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Timothy Chen
>
>
Re: Review Request 41728: Removed docker provisioner port slave flags.
Posted by Jie Yu <yu...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41728/#review112331
-----------------------------------------------------------
Ship it!
Again, great cleanup! Thanks Tim!
- Jie Yu
On Dec. 26, 2015, 8:28 p.m., Timothy Chen wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41728/
> -----------------------------------------------------------
>
> (Updated Dec. 26, 2015, 8:28 p.m.)
>
>
> Review request for mesos, Gilbert Song, Jie Yu, and Jojy Varghese.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Removed docker provisioner port slave flags.
>
>
> Diffs
> -----
>
> src/slave/containerizer/mesos/provisioner/docker/registry_client.hpp 798431c737691405a15989b1eb9ed5319ea0dacd
> src/slave/containerizer/mesos/provisioner/docker/registry_puller.cpp 7cdb15b9529eab82867b3470a016bb8ad09ff250
> src/slave/flags.hpp 1250786d1bdc8b312a1912a37ac8aac373dd5ec9
> src/slave/flags.cpp c4343ab7ff7b7b4d2c335119d41319b0779d2806
> src/tests/containerizer/provisioner_docker_tests.cpp bb142f5ea99e8ea9b20a896f95ae37aa1d8d3f98
>
> Diff: https://reviews.apache.org/r/41728/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Timothy Chen
>
>
Re: Review Request 41728: Removed docker provisioner port slave flags.
Posted by Joerg Schad <jo...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41728/#review111928
-----------------------------------------------------------
Basically all the same: Let us try to keep the documentation in sync :-).
One other question: Do we have a procedure for removing such flags? (i.e. mail to dev/user list, potential deprecation cycle?)?
src/slave/flags.cpp (line 124)
<https://reviews.apache.org/r/41728/#comment172226>
We should update the configuration documentation (https://github.com/apache/mesos/blob/master/docs/configuration.md)
src/slave/flags.cpp
<https://reviews.apache.org/r/41728/#comment172227>
We should update the configuration documentation (https://github.com/apache/mesos/blob/master/docs/configuration.md)
src/slave/flags.cpp (line 144)
<https://reviews.apache.org/r/41728/#comment172225>
We should update the configuration documentation (https://github.com/apache/mesos/blob/master/docs/configuration.md)
src/slave/flags.cpp
<https://reviews.apache.org/r/41728/#comment172224>
We should update the configuration documentation (https://github.com/apache/mesos/blob/master/docs/configuration.md)
- Joerg Schad
On Dec. 26, 2015, 8:28 p.m., Timothy Chen wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41728/
> -----------------------------------------------------------
>
> (Updated Dec. 26, 2015, 8:28 p.m.)
>
>
> Review request for mesos, Gilbert Song, Jie Yu, and Jojy Varghese.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Removed docker provisioner port slave flags.
>
>
> Diffs
> -----
>
> src/slave/containerizer/mesos/provisioner/docker/registry_client.hpp 798431c737691405a15989b1eb9ed5319ea0dacd
> src/slave/containerizer/mesos/provisioner/docker/registry_puller.cpp 7cdb15b9529eab82867b3470a016bb8ad09ff250
> src/slave/flags.hpp 1250786d1bdc8b312a1912a37ac8aac373dd5ec9
> src/slave/flags.cpp c4343ab7ff7b7b4d2c335119d41319b0779d2806
> src/tests/containerizer/provisioner_docker_tests.cpp bb142f5ea99e8ea9b20a896f95ae37aa1d8d3f98
>
> Diff: https://reviews.apache.org/r/41728/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Timothy Chen
>
>