You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@oozie.apache.org by "Han Xiao (JIRA)" <ji...@apache.org> on 2012/04/21 06:14:48 UTC
[jira] [Created] (OOZIE-817) Fix the unreasonable definition of the
schema to fs action
Han Xiao created OOZIE-817:
------------------------------
Summary: Fix the unreasonable definition of the schema to fs action
Key: OOZIE-817
URL: https://issues.apache.org/jira/browse/OOZIE-817
Project: Oozie
Issue Type: Bug
Components: client
Affects Versions: trunk
Reporter: Han Xiao
Fix For: trunk
Schema of fs action require the fs operations must follow the sequence of "delete, mkdir, move, chmod".
The limitation is not reasonable, oozie should allow fs operations to be done in any sequence users like to.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (OOZIE-817) Fix the unreasonable definition of
the schema to fs action
Posted by "jiraposter@reviews.apache.org (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OOZIE-817?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13260177#comment-13260177 ]
jiraposter@reviews.apache.org commented on OOZIE-817:
-----------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4835/
-----------------------------------------------------------
(Updated 2012-04-24 03:25:26.597167)
Review request for oozie.
Summary
-------
Schema of fs action require the fs operations must follow the sequence of "delete, mkdir, move, chmod".
The limitation is not reasonable, oozie should allow fs operations to be done in any sequence users like to.
This addresses bug OOZIE-817.
https://issues.apache.org/jira/browse/OOZIE-817
Diffs (updated)
-----
http://svn.apache.org/repos/asf/incubator/oozie/trunk/client/src/main/resources/oozie-workflow-0.1.xsd 1327027
http://svn.apache.org/repos/asf/incubator/oozie/trunk/client/src/main/resources/oozie-workflow-0.2.5.xsd 1327027
http://svn.apache.org/repos/asf/incubator/oozie/trunk/client/src/main/resources/oozie-workflow-0.2.xsd 1327027
http://svn.apache.org/repos/asf/incubator/oozie/trunk/client/src/main/resources/oozie-workflow-0.3.xsd 1327027
http://svn.apache.org/repos/asf/incubator/oozie/trunk/core/src/test/java/org/apache/oozie/service/TestLiteWorkflowAppService.java 1327027
http://svn.apache.org/repos/asf/incubator/oozie/trunk/core/src/test/resources/wf-schema-valid.xml 1327027
Diff: https://reviews.apache.org/r/4835/diff
Testing
-------
* Revise the TestLiteWorkflowAppService to add testing for fs action's schema.
* All testcase are passed.
Thanks,
Han
> Fix the unreasonable definition of the schema to fs action
> ----------------------------------------------------------
>
> Key: OOZIE-817
> URL: https://issues.apache.org/jira/browse/OOZIE-817
> Project: Oozie
> Issue Type: Bug
> Components: client
> Affects Versions: trunk
> Reporter: Han Xiao
> Fix For: trunk
>
>
> Schema of fs action require the fs operations must follow the sequence of "delete, mkdir, move, chmod".
> The limitation is not reasonable, oozie should allow fs operations to be done in any sequence users like to.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (OOZIE-817) Fix the unreasonable definition of
the schema to fs action
Posted by "jiraposter@reviews.apache.org (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OOZIE-817?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13259801#comment-13259801 ]
jiraposter@reviews.apache.org commented on OOZIE-817:
-----------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4835/#review7147
-----------------------------------------------------------
i don't think the patch will work as expected as the following won't work:
mkdir
delete
mkdir
delete
AFAIK, XML schemas have the limitation that random order is not possible.
- Alejandro
On 2012-04-21 04:26:17, Han Xiao wrote:
bq.
bq. -----------------------------------------------------------
bq. This is an automatically generated e-mail. To reply, visit:
bq. https://reviews.apache.org/r/4835/
bq. -----------------------------------------------------------
bq.
bq. (Updated 2012-04-21 04:26:17)
bq.
bq.
bq. Review request for oozie.
bq.
bq.
bq. Summary
bq. -------
bq.
bq. Schema of fs action require the fs operations must follow the sequence of "delete, mkdir, move, chmod".
bq. The limitation is not reasonable, oozie should allow fs operations to be done in any sequence users like to.
bq.
bq.
bq. This addresses bug OOZIE-817.
bq. https://issues.apache.org/jira/browse/OOZIE-817
bq.
bq.
bq. Diffs
bq. -----
bq.
bq. http://svn.apache.org/repos/asf/incubator/oozie/trunk/client/src/main/resources/oozie-workflow-0.1.xsd 1327027
bq. http://svn.apache.org/repos/asf/incubator/oozie/trunk/client/src/main/resources/oozie-workflow-0.2.5.xsd 1327027
bq. http://svn.apache.org/repos/asf/incubator/oozie/trunk/client/src/main/resources/oozie-workflow-0.2.xsd 1327027
bq. http://svn.apache.org/repos/asf/incubator/oozie/trunk/client/src/main/resources/oozie-workflow-0.3.xsd 1327027
bq. http://svn.apache.org/repos/asf/incubator/oozie/trunk/core/src/test/java/org/apache/oozie/service/TestLiteWorkflowAppService.java 1327027
bq. http://svn.apache.org/repos/asf/incubator/oozie/trunk/core/src/test/resources/wf-schema-valid.xml 1327027
bq.
bq. Diff: https://reviews.apache.org/r/4835/diff
bq.
bq.
bq. Testing
bq. -------
bq.
bq. * Revise the TestLiteWorkflowAppService to add testing for fs action's schema.
bq. * All testcase are passed.
bq.
bq.
bq. Thanks,
bq.
bq. Han
bq.
bq.
> Fix the unreasonable definition of the schema to fs action
> ----------------------------------------------------------
>
> Key: OOZIE-817
> URL: https://issues.apache.org/jira/browse/OOZIE-817
> Project: Oozie
> Issue Type: Bug
> Components: client
> Affects Versions: trunk
> Reporter: Han Xiao
> Fix For: trunk
>
>
> Schema of fs action require the fs operations must follow the sequence of "delete, mkdir, move, chmod".
> The limitation is not reasonable, oozie should allow fs operations to be done in any sequence users like to.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (OOZIE-817) Fix the unreasonable definition of
the schema to fs action
Posted by "jiraposter@reviews.apache.org (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OOZIE-817?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13258765#comment-13258765 ]
jiraposter@reviews.apache.org commented on OOZIE-817:
-----------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4835/
-----------------------------------------------------------
Review request for oozie.
Summary
-------
Schema of fs action require the fs operations must follow the sequence of "delete, mkdir, move, chmod".
The limitation is not reasonable, oozie should allow fs operations to be done in any sequence users like to.
This addresses bug OOZIE-817.
https://issues.apache.org/jira/browse/OOZIE-817
Diffs
-----
http://svn.apache.org/repos/asf/incubator/oozie/trunk/client/src/main/resources/oozie-workflow-0.1.xsd 1327027
http://svn.apache.org/repos/asf/incubator/oozie/trunk/client/src/main/resources/oozie-workflow-0.2.5.xsd 1327027
http://svn.apache.org/repos/asf/incubator/oozie/trunk/client/src/main/resources/oozie-workflow-0.2.xsd 1327027
http://svn.apache.org/repos/asf/incubator/oozie/trunk/client/src/main/resources/oozie-workflow-0.3.xsd 1327027
http://svn.apache.org/repos/asf/incubator/oozie/trunk/core/src/test/java/org/apache/oozie/service/TestLiteWorkflowAppService.java 1327027
http://svn.apache.org/repos/asf/incubator/oozie/trunk/core/src/test/resources/wf-schema-valid.xml 1327027
Diff: https://reviews.apache.org/r/4835/diff
Testing
-------
* Revise the TestLiteWorkflowAppService to add testing for fs action's schema.
* All testcase are passed.
Thanks,
Han
> Fix the unreasonable definition of the schema to fs action
> ----------------------------------------------------------
>
> Key: OOZIE-817
> URL: https://issues.apache.org/jira/browse/OOZIE-817
> Project: Oozie
> Issue Type: Bug
> Components: client
> Affects Versions: trunk
> Reporter: Han Xiao
> Fix For: trunk
>
>
> Schema of fs action require the fs operations must follow the sequence of "delete, mkdir, move, chmod".
> The limitation is not reasonable, oozie should allow fs operations to be done in any sequence users like to.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (OOZIE-817) Fix the unreasonable definition of
the schema to fs action
Posted by "jiraposter@reviews.apache.org (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OOZIE-817?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13261256#comment-13261256 ]
jiraposter@reviews.apache.org commented on OOZIE-817:
-----------------------------------------------------
bq. On 2012-04-23 17:46:35, Mona Chitnis wrote:
bq. > http://svn.apache.org/repos/asf/incubator/oozie/trunk/client/src/main/resources/oozie-workflow-0.1.xsd, line 187
bq. > <https://reviews.apache.org/r/4835/diff/1/?file=103683#file103683line187>
bq. >
bq. > Is occurrence of each operation limited to once?
bq.
bq. Han Xiao wrote:
bq. I am afraid there is no need. A choice element means that one and only one of elements in it must appear.
bq. If there is another element, it should be treated as another choice element.
bq.
bq. Mona Chitnis wrote:
bq. My question was more directed on the lines of Alejandro's comment. It that case being handled?
Yes. As i replied to Alejandro, the order could be random. Also update the testcase for fs schema to make sure.
Thank you.
- Han
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4835/#review7145
-----------------------------------------------------------
On 2012-04-24 03:25:26, Han Xiao wrote:
bq.
bq. -----------------------------------------------------------
bq. This is an automatically generated e-mail. To reply, visit:
bq. https://reviews.apache.org/r/4835/
bq. -----------------------------------------------------------
bq.
bq. (Updated 2012-04-24 03:25:26)
bq.
bq.
bq. Review request for oozie.
bq.
bq.
bq. Summary
bq. -------
bq.
bq. Schema of fs action require the fs operations must follow the sequence of "delete, mkdir, move, chmod".
bq. The limitation is not reasonable, oozie should allow fs operations to be done in any sequence users like to.
bq.
bq.
bq. This addresses bug OOZIE-817.
bq. https://issues.apache.org/jira/browse/OOZIE-817
bq.
bq.
bq. Diffs
bq. -----
bq.
bq. http://svn.apache.org/repos/asf/incubator/oozie/trunk/client/src/main/resources/oozie-workflow-0.1.xsd 1327027
bq. http://svn.apache.org/repos/asf/incubator/oozie/trunk/client/src/main/resources/oozie-workflow-0.2.5.xsd 1327027
bq. http://svn.apache.org/repos/asf/incubator/oozie/trunk/client/src/main/resources/oozie-workflow-0.2.xsd 1327027
bq. http://svn.apache.org/repos/asf/incubator/oozie/trunk/client/src/main/resources/oozie-workflow-0.3.xsd 1327027
bq. http://svn.apache.org/repos/asf/incubator/oozie/trunk/core/src/test/java/org/apache/oozie/service/TestLiteWorkflowAppService.java 1327027
bq. http://svn.apache.org/repos/asf/incubator/oozie/trunk/core/src/test/resources/wf-schema-valid.xml 1327027
bq.
bq. Diff: https://reviews.apache.org/r/4835/diff
bq.
bq.
bq. Testing
bq. -------
bq.
bq. * Revise the TestLiteWorkflowAppService to add testing for fs action's schema.
bq. * All testcase are passed.
bq.
bq.
bq. Thanks,
bq.
bq. Han
bq.
bq.
> Fix the unreasonable definition of the schema to fs action
> ----------------------------------------------------------
>
> Key: OOZIE-817
> URL: https://issues.apache.org/jira/browse/OOZIE-817
> Project: Oozie
> Issue Type: Bug
> Components: client
> Affects Versions: trunk
> Reporter: Han Xiao
> Fix For: trunk
>
>
> Schema of fs action require the fs operations must follow the sequence of "delete, mkdir, move, chmod".
> The limitation is not reasonable, oozie should allow fs operations to be done in any sequence users like to.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (OOZIE-817) Fix the unreasonable definition of
the schema to fs action
Posted by "jiraposter@reviews.apache.org (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OOZIE-817?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13260176#comment-13260176 ]
jiraposter@reviews.apache.org commented on OOZIE-817:
-----------------------------------------------------
bq. On 2012-04-23 17:46:35, Mona Chitnis wrote:
bq. > http://svn.apache.org/repos/asf/incubator/oozie/trunk/core/src/test/resources/wf-schema-valid.xml, line 94
bq. > <https://reviews.apache.org/r/4835/diff/1/?file=103688#file103688line94>
bq. >
bq. > whitespace
have fixed it
bq. On 2012-04-23 17:46:35, Mona Chitnis wrote:
bq. > http://svn.apache.org/repos/asf/incubator/oozie/trunk/core/src/test/java/org/apache/oozie/service/TestLiteWorkflowAppService.java, line 288
bq. > <https://reviews.apache.org/r/4835/diff/1/?file=103687#file103687line288>
bq. >
bq. > remove extra whitespaces.
have fixed it
bq. On 2012-04-23 17:46:35, Mona Chitnis wrote:
bq. > http://svn.apache.org/repos/asf/incubator/oozie/trunk/client/src/main/resources/oozie-workflow-0.1.xsd, line 187
bq. > <https://reviews.apache.org/r/4835/diff/1/?file=103683#file103683line187>
bq. >
bq. > Is occurrence of each operation limited to once?
I am afraid there is no need. A choice element means that one and only one of elements in it must appear.
If there is another element, it should be treated as another choice element.
- Han
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4835/#review7145
-----------------------------------------------------------
On 2012-04-21 04:26:17, Han Xiao wrote:
bq.
bq. -----------------------------------------------------------
bq. This is an automatically generated e-mail. To reply, visit:
bq. https://reviews.apache.org/r/4835/
bq. -----------------------------------------------------------
bq.
bq. (Updated 2012-04-21 04:26:17)
bq.
bq.
bq. Review request for oozie.
bq.
bq.
bq. Summary
bq. -------
bq.
bq. Schema of fs action require the fs operations must follow the sequence of "delete, mkdir, move, chmod".
bq. The limitation is not reasonable, oozie should allow fs operations to be done in any sequence users like to.
bq.
bq.
bq. This addresses bug OOZIE-817.
bq. https://issues.apache.org/jira/browse/OOZIE-817
bq.
bq.
bq. Diffs
bq. -----
bq.
bq. http://svn.apache.org/repos/asf/incubator/oozie/trunk/client/src/main/resources/oozie-workflow-0.1.xsd 1327027
bq. http://svn.apache.org/repos/asf/incubator/oozie/trunk/client/src/main/resources/oozie-workflow-0.2.5.xsd 1327027
bq. http://svn.apache.org/repos/asf/incubator/oozie/trunk/client/src/main/resources/oozie-workflow-0.2.xsd 1327027
bq. http://svn.apache.org/repos/asf/incubator/oozie/trunk/client/src/main/resources/oozie-workflow-0.3.xsd 1327027
bq. http://svn.apache.org/repos/asf/incubator/oozie/trunk/core/src/test/java/org/apache/oozie/service/TestLiteWorkflowAppService.java 1327027
bq. http://svn.apache.org/repos/asf/incubator/oozie/trunk/core/src/test/resources/wf-schema-valid.xml 1327027
bq.
bq. Diff: https://reviews.apache.org/r/4835/diff
bq.
bq.
bq. Testing
bq. -------
bq.
bq. * Revise the TestLiteWorkflowAppService to add testing for fs action's schema.
bq. * All testcase are passed.
bq.
bq.
bq. Thanks,
bq.
bq. Han
bq.
bq.
> Fix the unreasonable definition of the schema to fs action
> ----------------------------------------------------------
>
> Key: OOZIE-817
> URL: https://issues.apache.org/jira/browse/OOZIE-817
> Project: Oozie
> Issue Type: Bug
> Components: client
> Affects Versions: trunk
> Reporter: Han Xiao
> Fix For: trunk
>
>
> Schema of fs action require the fs operations must follow the sequence of "delete, mkdir, move, chmod".
> The limitation is not reasonable, oozie should allow fs operations to be done in any sequence users like to.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (OOZIE-817) Fix the unreasonable definition of
the schema to fs action
Posted by "jiraposter@reviews.apache.org (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OOZIE-817?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13264079#comment-13264079 ]
jiraposter@reviews.apache.org commented on OOZIE-817:
-----------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4835/
-----------------------------------------------------------
(Updated 2012-04-27 23:12:14.507795)
Review request for oozie.
Summary (updated)
-------
Schema of fs action require the fs operations must follow the sequence of "delete, mkdir, move, chmod".
The limitation is not reasonable, oozie should allow fs operations to be done in any sequence users like to.
This addresses bug OOZIE-817.
https://issues.apache.org/jira/browse/OOZIE-817
Diffs
-----
http://svn.apache.org/repos/asf/incubator/oozie/trunk/core/src/test/resources/wf-schema-valid.xml 1327027
http://svn.apache.org/repos/asf/incubator/oozie/trunk/core/src/test/java/org/apache/oozie/service/TestLiteWorkflowAppService.java 1327027
http://svn.apache.org/repos/asf/incubator/oozie/trunk/client/src/main/resources/oozie-workflow-0.3.xsd 1327027
http://svn.apache.org/repos/asf/incubator/oozie/trunk/client/src/main/resources/oozie-workflow-0.2.xsd 1327027
http://svn.apache.org/repos/asf/incubator/oozie/trunk/client/src/main/resources/oozie-workflow-0.2.5.xsd 1327027
http://svn.apache.org/repos/asf/incubator/oozie/trunk/client/src/main/resources/oozie-workflow-0.1.xsd 1327027
Diff: https://reviews.apache.org/r/4835/diff
Testing
-------
* Revise the TestLiteWorkflowAppService to add testing for fs action's schema.
* All testcase are passed.
Thanks,
Han
> Fix the unreasonable definition of the schema to fs action
> ----------------------------------------------------------
>
> Key: OOZIE-817
> URL: https://issues.apache.org/jira/browse/OOZIE-817
> Project: Oozie
> Issue Type: Bug
> Components: client
> Affects Versions: trunk
> Reporter: Han Xiao
> Fix For: trunk
>
>
> Schema of fs action require the fs operations must follow the sequence of "delete, mkdir, move, chmod".
> The limitation is not reasonable, oozie should allow fs operations to be done in any sequence users like to.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (OOZIE-817) Fix the unreasonable definition of
the schema to fs action
Posted by "jiraposter@reviews.apache.org (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OOZIE-817?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13261257#comment-13261257 ]
jiraposter@reviews.apache.org commented on OOZIE-817:
-----------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4835/
-----------------------------------------------------------
(Updated 2012-04-25 02:47:23.623256)
Review request for oozie.
Changes
-------
Update test for fs schema by adding duplicated actions in action sequence.
Summary
-------
Schema of fs action require the fs operations must follow the sequence of "delete, mkdir, move, chmod".
The limitation is not reasonable, oozie should allow fs operations to be done in any sequence users like to.
This addresses bug OOZIE-817.
https://issues.apache.org/jira/browse/OOZIE-817
Diffs (updated)
-----
http://svn.apache.org/repos/asf/incubator/oozie/trunk/core/src/test/resources/wf-schema-valid.xml 1327027
http://svn.apache.org/repos/asf/incubator/oozie/trunk/core/src/test/java/org/apache/oozie/service/TestLiteWorkflowAppService.java 1327027
http://svn.apache.org/repos/asf/incubator/oozie/trunk/client/src/main/resources/oozie-workflow-0.3.xsd 1327027
http://svn.apache.org/repos/asf/incubator/oozie/trunk/client/src/main/resources/oozie-workflow-0.2.xsd 1327027
http://svn.apache.org/repos/asf/incubator/oozie/trunk/client/src/main/resources/oozie-workflow-0.2.5.xsd 1327027
http://svn.apache.org/repos/asf/incubator/oozie/trunk/client/src/main/resources/oozie-workflow-0.1.xsd 1327027
Diff: https://reviews.apache.org/r/4835/diff
Testing
-------
* Revise the TestLiteWorkflowAppService to add testing for fs action's schema.
* All testcase are passed.
Thanks,
Han
> Fix the unreasonable definition of the schema to fs action
> ----------------------------------------------------------
>
> Key: OOZIE-817
> URL: https://issues.apache.org/jira/browse/OOZIE-817
> Project: Oozie
> Issue Type: Bug
> Components: client
> Affects Versions: trunk
> Reporter: Han Xiao
> Fix For: trunk
>
>
> Schema of fs action require the fs operations must follow the sequence of "delete, mkdir, move, chmod".
> The limitation is not reasonable, oozie should allow fs operations to be done in any sequence users like to.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (OOZIE-817) Fix the unreasonable definition of
the schema to fs action
Posted by "jiraposter@reviews.apache.org (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OOZIE-817?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13262712#comment-13262712 ]
jiraposter@reviews.apache.org commented on OOZIE-817:
-----------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4835/#review7266
-----------------------------------------------------------
Ship it!
+1 my bad, patch works jus fine, thxs
- Alejandro
On 2012-04-25 02:47:23, Han Xiao wrote:
bq.
bq. -----------------------------------------------------------
bq. This is an automatically generated e-mail. To reply, visit:
bq. https://reviews.apache.org/r/4835/
bq. -----------------------------------------------------------
bq.
bq. (Updated 2012-04-25 02:47:23)
bq.
bq.
bq. Review request for oozie.
bq.
bq.
bq. Summary
bq. -------
bq.
bq. Schema of fs action require the fs operations must follow the sequence of "delete, mkdir, move, chmod".
bq. The limitation is not reasonable, oozie should allow fs operations to be done in any sequence users like to.
bq.
bq.
bq. This addresses bug OOZIE-817.
bq. https://issues.apache.org/jira/browse/OOZIE-817
bq.
bq.
bq. Diffs
bq. -----
bq.
bq. http://svn.apache.org/repos/asf/incubator/oozie/trunk/core/src/test/resources/wf-schema-valid.xml 1327027
bq. http://svn.apache.org/repos/asf/incubator/oozie/trunk/core/src/test/java/org/apache/oozie/service/TestLiteWorkflowAppService.java 1327027
bq. http://svn.apache.org/repos/asf/incubator/oozie/trunk/client/src/main/resources/oozie-workflow-0.3.xsd 1327027
bq. http://svn.apache.org/repos/asf/incubator/oozie/trunk/client/src/main/resources/oozie-workflow-0.2.xsd 1327027
bq. http://svn.apache.org/repos/asf/incubator/oozie/trunk/client/src/main/resources/oozie-workflow-0.2.5.xsd 1327027
bq. http://svn.apache.org/repos/asf/incubator/oozie/trunk/client/src/main/resources/oozie-workflow-0.1.xsd 1327027
bq.
bq. Diff: https://reviews.apache.org/r/4835/diff
bq.
bq.
bq. Testing
bq. -------
bq.
bq. * Revise the TestLiteWorkflowAppService to add testing for fs action's schema.
bq. * All testcase are passed.
bq.
bq.
bq. Thanks,
bq.
bq. Han
bq.
bq.
> Fix the unreasonable definition of the schema to fs action
> ----------------------------------------------------------
>
> Key: OOZIE-817
> URL: https://issues.apache.org/jira/browse/OOZIE-817
> Project: Oozie
> Issue Type: Bug
> Components: client
> Affects Versions: trunk
> Reporter: Han Xiao
> Fix For: trunk
>
>
> Schema of fs action require the fs operations must follow the sequence of "delete, mkdir, move, chmod".
> The limitation is not reasonable, oozie should allow fs operations to be done in any sequence users like to.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (OOZIE-817) Fix the unreasonable definition of
the schema to fs action
Posted by "jiraposter@reviews.apache.org (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OOZIE-817?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13259770#comment-13259770 ]
jiraposter@reviews.apache.org commented on OOZIE-817:
-----------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4835/#review7145
-----------------------------------------------------------
http://svn.apache.org/repos/asf/incubator/oozie/trunk/client/src/main/resources/oozie-workflow-0.1.xsd
<https://reviews.apache.org/r/4835/#comment15780>
Is occurrence of each operation limited to once?
http://svn.apache.org/repos/asf/incubator/oozie/trunk/core/src/test/java/org/apache/oozie/service/TestLiteWorkflowAppService.java
<https://reviews.apache.org/r/4835/#comment15778>
remove extra whitespaces.
http://svn.apache.org/repos/asf/incubator/oozie/trunk/core/src/test/resources/wf-schema-valid.xml
<https://reviews.apache.org/r/4835/#comment15779>
whitespace
- Mona
On 2012-04-21 04:26:17, Han Xiao wrote:
bq.
bq. -----------------------------------------------------------
bq. This is an automatically generated e-mail. To reply, visit:
bq. https://reviews.apache.org/r/4835/
bq. -----------------------------------------------------------
bq.
bq. (Updated 2012-04-21 04:26:17)
bq.
bq.
bq. Review request for oozie.
bq.
bq.
bq. Summary
bq. -------
bq.
bq. Schema of fs action require the fs operations must follow the sequence of "delete, mkdir, move, chmod".
bq. The limitation is not reasonable, oozie should allow fs operations to be done in any sequence users like to.
bq.
bq.
bq. This addresses bug OOZIE-817.
bq. https://issues.apache.org/jira/browse/OOZIE-817
bq.
bq.
bq. Diffs
bq. -----
bq.
bq. http://svn.apache.org/repos/asf/incubator/oozie/trunk/client/src/main/resources/oozie-workflow-0.1.xsd 1327027
bq. http://svn.apache.org/repos/asf/incubator/oozie/trunk/client/src/main/resources/oozie-workflow-0.2.5.xsd 1327027
bq. http://svn.apache.org/repos/asf/incubator/oozie/trunk/client/src/main/resources/oozie-workflow-0.2.xsd 1327027
bq. http://svn.apache.org/repos/asf/incubator/oozie/trunk/client/src/main/resources/oozie-workflow-0.3.xsd 1327027
bq. http://svn.apache.org/repos/asf/incubator/oozie/trunk/core/src/test/java/org/apache/oozie/service/TestLiteWorkflowAppService.java 1327027
bq. http://svn.apache.org/repos/asf/incubator/oozie/trunk/core/src/test/resources/wf-schema-valid.xml 1327027
bq.
bq. Diff: https://reviews.apache.org/r/4835/diff
bq.
bq.
bq. Testing
bq. -------
bq.
bq. * Revise the TestLiteWorkflowAppService to add testing for fs action's schema.
bq. * All testcase are passed.
bq.
bq.
bq. Thanks,
bq.
bq. Han
bq.
bq.
> Fix the unreasonable definition of the schema to fs action
> ----------------------------------------------------------
>
> Key: OOZIE-817
> URL: https://issues.apache.org/jira/browse/OOZIE-817
> Project: Oozie
> Issue Type: Bug
> Components: client
> Affects Versions: trunk
> Reporter: Han Xiao
> Fix For: trunk
>
>
> Schema of fs action require the fs operations must follow the sequence of "delete, mkdir, move, chmod".
> The limitation is not reasonable, oozie should allow fs operations to be done in any sequence users like to.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Resolved] (OOZIE-817) Fix the unreasonable definition of
the schema to fs action
Posted by "Alejandro Abdelnur (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OOZIE-817?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Alejandro Abdelnur resolved OOZIE-817.
--------------------------------------
Resolution: Fixed
Thanks Han Xiao. Committed to trunk
> Fix the unreasonable definition of the schema to fs action
> ----------------------------------------------------------
>
> Key: OOZIE-817
> URL: https://issues.apache.org/jira/browse/OOZIE-817
> Project: Oozie
> Issue Type: Bug
> Components: client
> Affects Versions: trunk
> Reporter: Han Xiao
> Fix For: trunk
>
>
> Schema of fs action require the fs operations must follow the sequence of "delete, mkdir, move, chmod".
> The limitation is not reasonable, oozie should allow fs operations to be done in any sequence users like to.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (OOZIE-817) Fix the unreasonable definition of
the schema to fs action
Posted by "jiraposter@reviews.apache.org (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OOZIE-817?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13261102#comment-13261102 ]
jiraposter@reviews.apache.org commented on OOZIE-817:
-----------------------------------------------------
bq. On 2012-04-23 17:46:35, Mona Chitnis wrote:
bq. > http://svn.apache.org/repos/asf/incubator/oozie/trunk/client/src/main/resources/oozie-workflow-0.1.xsd, line 187
bq. > <https://reviews.apache.org/r/4835/diff/1/?file=103683#file103683line187>
bq. >
bq. > Is occurrence of each operation limited to once?
bq.
bq. Han Xiao wrote:
bq. I am afraid there is no need. A choice element means that one and only one of elements in it must appear.
bq. If there is another element, it should be treated as another choice element.
My question was more directed on the lines of Alejandro's comment. It that case being handled?
- Mona
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4835/#review7145
-----------------------------------------------------------
On 2012-04-24 03:25:26, Han Xiao wrote:
bq.
bq. -----------------------------------------------------------
bq. This is an automatically generated e-mail. To reply, visit:
bq. https://reviews.apache.org/r/4835/
bq. -----------------------------------------------------------
bq.
bq. (Updated 2012-04-24 03:25:26)
bq.
bq.
bq. Review request for oozie.
bq.
bq.
bq. Summary
bq. -------
bq.
bq. Schema of fs action require the fs operations must follow the sequence of "delete, mkdir, move, chmod".
bq. The limitation is not reasonable, oozie should allow fs operations to be done in any sequence users like to.
bq.
bq.
bq. This addresses bug OOZIE-817.
bq. https://issues.apache.org/jira/browse/OOZIE-817
bq.
bq.
bq. Diffs
bq. -----
bq.
bq. http://svn.apache.org/repos/asf/incubator/oozie/trunk/client/src/main/resources/oozie-workflow-0.1.xsd 1327027
bq. http://svn.apache.org/repos/asf/incubator/oozie/trunk/client/src/main/resources/oozie-workflow-0.2.5.xsd 1327027
bq. http://svn.apache.org/repos/asf/incubator/oozie/trunk/client/src/main/resources/oozie-workflow-0.2.xsd 1327027
bq. http://svn.apache.org/repos/asf/incubator/oozie/trunk/client/src/main/resources/oozie-workflow-0.3.xsd 1327027
bq. http://svn.apache.org/repos/asf/incubator/oozie/trunk/core/src/test/java/org/apache/oozie/service/TestLiteWorkflowAppService.java 1327027
bq. http://svn.apache.org/repos/asf/incubator/oozie/trunk/core/src/test/resources/wf-schema-valid.xml 1327027
bq.
bq. Diff: https://reviews.apache.org/r/4835/diff
bq.
bq.
bq. Testing
bq. -------
bq.
bq. * Revise the TestLiteWorkflowAppService to add testing for fs action's schema.
bq. * All testcase are passed.
bq.
bq.
bq. Thanks,
bq.
bq. Han
bq.
bq.
> Fix the unreasonable definition of the schema to fs action
> ----------------------------------------------------------
>
> Key: OOZIE-817
> URL: https://issues.apache.org/jira/browse/OOZIE-817
> Project: Oozie
> Issue Type: Bug
> Components: client
> Affects Versions: trunk
> Reporter: Han Xiao
> Fix For: trunk
>
>
> Schema of fs action require the fs operations must follow the sequence of "delete, mkdir, move, chmod".
> The limitation is not reasonable, oozie should allow fs operations to be done in any sequence users like to.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (OOZIE-817) Fix the unreasonable definition of
the schema to fs action
Posted by "jiraposter@reviews.apache.org (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OOZIE-817?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13261255#comment-13261255 ]
jiraposter@reviews.apache.org commented on OOZIE-817:
-----------------------------------------------------
bq. On 2012-04-23 18:17:36, Alejandro Abdelnur wrote:
bq. > i don't think the patch will work as expected as the following won't work:
bq. >
bq. > mkdir
bq. > delete
bq. > mkdir
bq. > delete
bq. >
bq. > AFAIK, XML schemas have the limitation that random order is not possible.
At first, i have the same idea with you.
However, after read the xml reference, I find using choice element could be a good method.
The sequence of "mkdir, delete, mkdir, delete" aslo works, and please just consider any of them is a choice element, an a choice element can be any in "delete, mkdir, move and chmod".
Thank you.
- Han
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4835/#review7147
-----------------------------------------------------------
On 2012-04-24 03:25:26, Han Xiao wrote:
bq.
bq. -----------------------------------------------------------
bq. This is an automatically generated e-mail. To reply, visit:
bq. https://reviews.apache.org/r/4835/
bq. -----------------------------------------------------------
bq.
bq. (Updated 2012-04-24 03:25:26)
bq.
bq.
bq. Review request for oozie.
bq.
bq.
bq. Summary
bq. -------
bq.
bq. Schema of fs action require the fs operations must follow the sequence of "delete, mkdir, move, chmod".
bq. The limitation is not reasonable, oozie should allow fs operations to be done in any sequence users like to.
bq.
bq.
bq. This addresses bug OOZIE-817.
bq. https://issues.apache.org/jira/browse/OOZIE-817
bq.
bq.
bq. Diffs
bq. -----
bq.
bq. http://svn.apache.org/repos/asf/incubator/oozie/trunk/client/src/main/resources/oozie-workflow-0.1.xsd 1327027
bq. http://svn.apache.org/repos/asf/incubator/oozie/trunk/client/src/main/resources/oozie-workflow-0.2.5.xsd 1327027
bq. http://svn.apache.org/repos/asf/incubator/oozie/trunk/client/src/main/resources/oozie-workflow-0.2.xsd 1327027
bq. http://svn.apache.org/repos/asf/incubator/oozie/trunk/client/src/main/resources/oozie-workflow-0.3.xsd 1327027
bq. http://svn.apache.org/repos/asf/incubator/oozie/trunk/core/src/test/java/org/apache/oozie/service/TestLiteWorkflowAppService.java 1327027
bq. http://svn.apache.org/repos/asf/incubator/oozie/trunk/core/src/test/resources/wf-schema-valid.xml 1327027
bq.
bq. Diff: https://reviews.apache.org/r/4835/diff
bq.
bq.
bq. Testing
bq. -------
bq.
bq. * Revise the TestLiteWorkflowAppService to add testing for fs action's schema.
bq. * All testcase are passed.
bq.
bq.
bq. Thanks,
bq.
bq. Han
bq.
bq.
> Fix the unreasonable definition of the schema to fs action
> ----------------------------------------------------------
>
> Key: OOZIE-817
> URL: https://issues.apache.org/jira/browse/OOZIE-817
> Project: Oozie
> Issue Type: Bug
> Components: client
> Affects Versions: trunk
> Reporter: Han Xiao
> Fix For: trunk
>
>
> Schema of fs action require the fs operations must follow the sequence of "delete, mkdir, move, chmod".
> The limitation is not reasonable, oozie should allow fs operations to be done in any sequence users like to.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira