You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@druid.apache.org by GitBox <gi...@apache.org> on 2021/05/26 10:16:18 UTC
[GitHub] [druid] FrankChen021 opened a new pull request #11304: Add configuration suggestion to 'druid.indexer.storage.type'
FrankChen021 opened a new pull request #11304:
URL: https://github.com/apache/druid/pull/11304
### Description
During the discussion of #11140 , we found that some users configured `druid.indexer.storage.type` to `local` in their production environment. This is not we expect.
Although all example configurations have set `druid.indexer.storage.type` to `metadata`, there's no configuration suggestion in the doc to describe which one should be used.
So this PR adds some text in the doc to give explicit messages to users which one should be used in production.
This PR has:
- [X] been self-reviewed.
- [ ] using the [concurrency checklist](https://github.com/apache/druid/blob/master/dev/code-review/concurrency.md) (Remove this item if the PR doesn't have any relation to concurrency.)
- [ ] added documentation for new or modified features or behaviors.
- [ ] added Javadocs for most classes and all non-trivial methods. Linked related entities via Javadoc links.
- [ ] added or updated version, license, or notice information in [licenses.yaml](https://github.com/apache/druid/blob/master/dev/license.md)
- [ ] added comments explaining the "why" and the intent of the code wherever would not be obvious for an unfamiliar reader.
- [ ] added unit tests or modified existing tests to cover new code paths, ensuring the threshold for [code coverage](https://github.com/apache/druid/blob/master/dev/code-review/code-coverage.md) is met.
- [ ] added integration tests.
- [ ] been tested in a test Druid cluster.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org
[GitHub] [druid] suneet-s merged pull request #11304: Add configuration suggestion to 'druid.indexer.storage.type'
Posted by GitBox <gi...@apache.org>.
suneet-s merged pull request #11304:
URL: https://github.com/apache/druid/pull/11304
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org
[GitHub] [druid] suneet-s commented on pull request #11304: Add configuration suggestion to 'druid.indexer.storage.type'
Posted by GitBox <gi...@apache.org>.
suneet-s commented on pull request #11304:
URL: https://github.com/apache/druid/pull/11304#issuecomment-849647249
Overruling Travis - this is just a doc change
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org