You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by "linguini1 (via GitHub)" <gi...@apache.org> on 2025/02/06 20:44:20 UTC

[PR] system/uorb: require that LIBC_FLOATINGPOINT be enabled for DEBUG_UORB [nuttx-apps]

linguini1 opened a new pull request, #2987:
URL: https://github.com/apache/nuttx-apps/pull/2987

   ## Summary
   
   This pull request closes the issue raised [here](https://github.com/apache/nuttx/issues/15599).
   
   Now `DEBUG_UORB` depends on `LIBC_FLOATINGPOINT`. This is because it is not possible to view sensor debug output without this enabled, which is only a problem for systems without an FPU (systems with an FPU have this enabled by default).
   
   ## Impact
   
   Users now have to enable `LIBC_FLOATINGPOINT` on systems without an FPU in order to use `DEBUG_UORB`. The dependency marked with `depends on` means that the uORB debug option will not be visible until `LIBC_FLOATINGPOINT` is selected, but this was determined to be acceptable in the discussion under the linked issue.
   
   This prevents the annoyance of re-flashing the device because floating point printing was disabled, rendering debug output almost useless.
   
   I have also included a compile time error for the configuration mismatch.
   
   ## Testing
   
   Verified that enabling `LIBC_FLOATINGPOINT` caused `DEBUG_UORB` to appear and that the dependency was marked in Kconfig.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] system/uorb: require that LIBC_FLOATINGPOINT be enabled for DEBUG_UORB [nuttx-apps]

Posted by "raiden00pl (via GitHub)" <gi...@apache.org>.
raiden00pl merged PR #2987:
URL: https://github.com/apache/nuttx-apps/pull/2987


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] system/uorb: require that LIBC_FLOATINGPOINT be enabled for DEBUG_UORB [nuttx-apps]

Posted by "lupyuen (via GitHub)" <gi...@apache.org>.
lupyuen commented on PR #2987:
URL: https://github.com/apache/nuttx-apps/pull/2987#issuecomment-2641340730

   Yep it looks great thanks! Quick Hack: Normally I copy the `Description` section of the PR into the Commit Description :-)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] system/uorb: require that LIBC_FLOATINGPOINT be enabled for DEBUG_UORB [nuttx-apps]

Posted by "linguini1 (via GitHub)" <gi...@apache.org>.
linguini1 commented on PR #2987:
URL: https://github.com/apache/nuttx-apps/pull/2987#issuecomment-2641327078

   Thanks @lupyuen and @cederom! I had misunderstood the commit description to just be the short description, not a detailed one. I have updated the commit message and added testing logs. Let me know if anything else is required, I'll adhere to this better going forward!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] system/uorb: require that LIBC_FLOATINGPOINT be enabled for DEBUG_UORB [nuttx-apps]

Posted by "lupyuen (via GitHub)" <gi...@apache.org>.
lupyuen commented on PR #2987:
URL: https://github.com/apache/nuttx-apps/pull/2987#issuecomment-2641174964

   @linguini1 Could you fill in the Description inside the Commit? As discussed in the Mailing List:
   https://lists.apache.org/thread/mn4l1tmr6fj46o2y9vvrmfcrgyo48s5d
   
   Thanks for all your awesome contributions! :-)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org