[GitHub] [arrow-datafusion] viirya commented on pull request #6792: Use checked division kernel

["viirya (via GitHub)" <gi...@apache.org>]

viirya commented on PR #6792:
URL: https://github.com/apache/arrow-datafusion/pull/6792#issuecomment-1612360780

   Hmm, it is inconsistent. We should fix it. But we will prefer default behavior is to get null instead of query error. That is story of Spark but I agree DataFusion doesn't necessarily to follow it at all.
   
   > ... nulls in non-nullable columns, and is pretty surprising.
   
   Is it an issue? In Spark, Divide expression output is nullable always. I think producing null from non-nullable input columns is totally fine if it follows the expression's output type definition.
   
   So the issue is more about inconsistency.
   
   Looks okay to me.
   
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org