You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by "rusackas (via GitHub)" <gi...@apache.org> on 2026/10/12 12:02:10 UTC
Re: [PR] fix(alerts): resolve async chart data when loading report filter values [superset]
rusackas commented on PR #43793:
URL: https://github.com/apache/superset/pull/43793#issuecomment-6123866404
Thanks @dpreuss, routing the 202 through `handleChartDataResponse` is the right fix and matches what Drill By does.
One gap though. You added the `.catch()` toast in `onChangeDashboardFilter`, but `fetchDashboardFilterValues` now awaits `handleChartDataResponse` too and its callers (`addNativeFilterOptions` and the time-filter branch of `onChangeDashboardFilter`) don't catch. If the async job fails, that's an unhandled rejection with no feedback. Could you give it the same treatment?
The `babel-extract` failure looks like the translation bot noise rather than something from this change, so I wouldn't chase it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org